Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove required files/executables for building the latest stable version of the project #772

Closed
EraOSBeta opened this issue Dec 31, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@EraOSBeta
Copy link
Collaborator

EraOSBeta commented Dec 31, 2024

Description

If I remember correctly, the current behavior of @efroemling's files server is to remove files that have not been part of the latest commit's build requirements for 90 (or 60, don't remember) days. This poses an issue were support for prefabs is dropped for ALL stable versions of the game when it's taking a long time to stabilize the newest beta version of the game. As of right now, support for 1.7.36 has been dropped even though it's the latest stable version of the game.

Solution

The file server should treat files for stable versions as a LTS version and keep on supporting them no matter how long they have been there until the next version becomes stable + 90 extra days. Since there are many commits in the project, the server can check which commit it should consider to be the current LTS version by checking which commit the latest tag in the repository refers to.

Alternatives

An alternative would be to host an archive of efrocache for every commit on an external third-party website; but I wouldn't personally like that.

@EraOSBeta EraOSBeta added the enhancement New feature or request label Dec 31, 2024
@Elowix
Copy link

Elowix commented Dec 31, 2024

😃😃😃

@HypeStratex
Copy link

Well said, important point.
Especially for ones who are working on older builds, this problem makes it impossible to build one, which is really annoying.

@Loup-Garou911XD
Copy link
Contributor

The cache is stored for a year now as stated by Efro so it should be good now hopefully
also asset packages should help mitigate this problem further by keeping the size of cache to minimum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants