Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inliner tries to inline favicons #2

Open
dotherightthing opened this issue Jul 3, 2018 · 0 comments
Open

Inliner tries to inline favicons #2

dotherightthing opened this issue Jul 3, 2018 · 0 comments

Comments

@dotherightthing
Copy link

Several favicons are referenced in my static HTML template:

<!-- Favicons -->
<link rel="apple-touch-icon" href="../img/favicons/apple-touch-icon.png?v=A0Rqr8Y59x" sizes="180x180">
<link rel="icon" type="image/png" href="../img/favicons/favicon-32x32.png?v=A0Rqr8Y59x" sizes="32x32">
<link rel="icon" type="image/png" href="../img/favicons/favicon-16x16.png?v=A0Rqr8Y59x" sizes="16x16">
<link rel="manifest" href="../img/favicons/site.webmanifest?v=A0Rqr8Y59x">
<link rel="mask-icon" href="../img/favicons/safari-pinned-tab.svg?v=A0Rqr8Y59x" color="#000000">

The inliner appear to (try to) inline these - but fails:

Inliner:
Error: ENOENT: no such file or directory, open '/path/to/dev_build/statics/../img/favicons/apple-touch-icon.png?v=A0Rqr8Y59x'
Inliner:
Error: ENOENT: no such file or directory, open '/path/to/dev_build/statics/../img/favicons/favicon-32x32.png?v=A0Rqr8Y59x'
Inliner:
Error: ENOENT: no such file or directory, open '/path/to/dev_build/statics/../img/favicons/favicon-16x16.png?v=A0Rqr8Y59x'
Inliner:
Error: ENOENT: no such file or directory, open '/path/to/dev_build/statics/../img/favicons/safari-pinned-tab.svg?v=A0Rqr8Y59x'
Inliner:
Error: ENOENT: no such file or directory, open '/path/to/dev_build/statics/../img/favicons/site.webmanifest?v=A0Rqr8Y59x'

I wouldn't expect images to be inlined, and my guess is that this is only occurring because these images are linked using href rather than src.

When I try to link these same images using <img src="..."> the inliner does not complain at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant