Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge wcs_astropy and wcs_astropy_ape14 #959

Open
pllim opened this issue Jun 2, 2021 · 3 comments
Open

Merge wcs_astropy and wcs_astropy_ape14 #959

pllim opened this issue Jun 2, 2021 · 3 comments
Assignees
@pllim
Labels
maintenance Work done to keep code maintained
Milestone
3.4

Comments

@pllim
Copy link
Collaborator

pllim commented Jun 2, 2021

Particularly, wcs_astropy_ape14 should just be renamed to wcs_astropy. At the same time, we deprecate wcs_astropy_ape14 and eventually remove it. So there should be only one astropy WCS interface and it is the one that follows Astropy APE 14.

As suggested by @ejeschke in #823 (comment).
@pllim pllim added the maintenance Work done to keep code maintained label Jun 2, 2021
@pllim pllim added this to the 3.3 milestone Jun 2, 2021
@pllim pllim self-assigned this Jun 2, 2021
@pllim pllim mentioned this issue Jun 2, 2021
Closed
@ejeschke
Copy link
Owner

ejeschke commented Jun 3, 2021

I think that as long as the one we end up with is working as well as the other (plus the extra functionality), then we are good. This is a little bit tricky issue because the WCS is used for sooo many different files!

@pllim

This comment has been minimized.

Sign in to view
@pllim
Copy link
Collaborator Author

pllim commented Jun 4, 2021

Oh ops... I replied to the wrong issue.

@pllim pllim mentioned this issue Jul 12, 2021
Merged
@ejeschke ejeschke modified the milestones: 3.3, 3.4 Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pllim pllim

Labels
maintenance Work done to keep code maintained
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
2 participants
@ejeschke @pllim