Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init scripts are for logstash #37

Open
amosshapira opened this issue Apr 17, 2015 · 3 comments
Open

init scripts are for logstash #37

amosshapira opened this issue Apr 17, 2015 · 3 comments

Comments

@amosshapira
Copy link

the init scripts provided are just a straight copy of the Java-based LogStash script, they don't run logstashforwarder.

@amosshapira amosshapira changed the title init script is for logstash init scripts are for logstash Apr 17, 2015
@electrical
Copy link

Hi,

With the new version of the module we use the init scripts of the package and not the added init scripts to the module.
I still need to remove those.
Sorry for that :-)

@oloc
Copy link

oloc commented Jul 8, 2015

In my opinion the best thing to do is to write a new template of the init script. Why ? Because we need to take care of the definition of some puppet arguments and transfer (sorry for my English) them to the init script.

Especially the configdir. It's require but hardcoded in the path :

    logstashforwarder_config { 'lsf-config':
      ensure  => 'present',
      config  => $main_config,
      path    => '/etc/logstash-forwarder.conf',
      tag     => "LSF_CONFIG_${::fqdn}",
      owner   => $logstashforwarder::logstashforwarder_user,
      group   => $logstashforwarder::logstashforwarder_group,
      notify  => $notify_service,
      require => File[$logstashforwarder::configdir]
    }

In fact I'm working on it. To be continue...

oloc pushed a commit to oloc/puppet-logstashforwarder that referenced this issue Jul 8, 2015
@oloc
Copy link

oloc commented Jul 8, 2015

My Pull Request is #56

oloc pushed a commit to oloc/puppet-logstashforwarder that referenced this issue Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants