Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we bump the minimum python version? #23387

Open
sbc100 opened this issue Jan 13, 2025 · 1 comment · May be fixed by #23417
Open

Should we bump the minimum python version? #23387

sbc100 opened this issue Jan 13, 2025 · 1 comment · May be fixed by #23417

Comments

@sbc100
Copy link
Collaborator

sbc100 commented Jan 13, 2025 •
edited
Loading

Currently out minimum supported python version is 3.6. However we do not currently have any tests that are run using python 3.6.

The current debian stable used python 3.11 (https://packages.debian.org/bookworm/python3) and ubuntu/focal LTS uses 3.8 (https://launchpad.net/ubuntu/focal/+package/python3)

emsdk currently ships with 3.9.2, but emscripten-core/emsdk#1477 is attempting to update it to 3.13.

See #23378
@sbc100 sbc100 mentioned this issue Jan 13, 2025
Closed
@eagleoflqj eagleoflqj mentioned this issue Jan 13, 2025
Closed
@sbc100
Copy link
Collaborator Author

sbc100 commented Jan 14, 2025

See

emscripten/tools/shared.py

Lines 23 to 26 in aca6884

# We depend on python 3.6 for fstring support
if sys.version_info < (3, 6):
print('error: emscripten requires python 3.6 or above', file=sys.stderr)
sys.exit(1)
for the place we enforce this.

sbc100 added a commit to sbc100/emscripten that referenced this issue Jan 15, 2025
@sbc100
Update min python version to 3.9
45be345 
The reason for picking 3.9 here is that it provides all the features
we currently have need of, and it available in the places we care about:

- debian/stable (bookworm): 3.11
- ubuntu/LTS (jammy): 3.10
- emsdk: 3.9.2

It also seems like a good idea to choose the emsdk version since that is
the version we use for testing and we don't currently have any mechanism
to test on anything older than that (which means we currently lack any
way to confirm that we really do support 3.6).

Replaces: emscripten-core#23378
Fixes: emscripten-core#23387
@sbc100 sbc100 linked a pull request Jan 15, 2025 that will close this issue
Open
sbc100 added a commit to sbc100/emscripten that referenced this issue Jan 15, 2025
@sbc100
Update min python version to 3.9
08bb5f8 
The reason for picking 3.9 here is that it provides all the features
we currently have need of, and it available in the places we care about:

- debian/stable (bookworm): 3.11
- ubuntu/LTS (jammy): 3.10
- emsdk: 3.9.2

It also seems like a good idea to choose the emsdk version since that is
the version we use for testing and we don't currently have any mechanism
to test on anything older than that (which means we currently lack any
way to confirm that we really do support 3.6).

Replaces: emscripten-core#23378
Fixes: emscripten-core#23387
sbc100 added a commit to sbc100/emscripten that referenced this issue Jan 15, 2025
@sbc100
Update min python version to 3.9
149e10e 
The reason for picking 3.9 here is that it provides all the features
we currently have need of, and it available in the places we care about:

- debian/stable (bookworm): 3.11
- ubuntu/LTS (jammy): 3.10
- emsdk: 3.9.2

It also seems like a good idea to choose the emsdk version since that is
the version we use for testing and we don't currently have any mechanism
to test on anything older than that (which means we currently lack any
way to confirm that we really do support 3.6).

Replaces: emscripten-core#23378
Fixes: emscripten-core#23387
sbc100 added a commit to sbc100/emscripten that referenced this issue Jan 15, 2025
@sbc100
Update min python version from 3.6 to 3.8
77ffc22 
The reason for picking 3.8 here is that it provides all the features
we currently have need of, and it available in the places we care about:

- debian/stable (bookworm): 3.11
- ubuntu/LTS (focal): 3.8
- emsdk: 3.9.2

Replaces: emscripten-core#23378
Fixes: emscripten-core#23387
sbc100 added a commit to sbc100/emscripten that referenced this issue Jan 15, 2025
@sbc100
Update min python version from 3.6 to 3.8
a8a2ffa 
The reason for picking 3.8 here is that it provides all the features
we currently have need of, and it available in the places we care about:

- debian/stable (bookworm): 3.11
- ubuntu/LTS (focal): 3.8
- emsdk: 3.9.2

Replaces: emscripten-core#23378
Fixes: emscripten-core#23387
sbc100 added a commit to sbc100/emscripten that referenced this issue Jan 15, 2025
@sbc100
Update min python version from 3.6 to 3.8
fc1ae1c 
The reason for picking 3.8 here is that it provides all the features
we currently have need of, and it available in the places we care about:

- debian/stable (bookworm): 3.11
- ubuntu/LTS (focal): 3.8
- emsdk: 3.9.2

Replaces: emscripten-core#23378
Fixes: emscripten-core#23387
sbc100 added a commit to sbc100/emscripten that referenced this issue Jan 22, 2025
@sbc100
Update min python version from 3.6 to 3.8
3a2d670 
The reason for picking 3.8 here is that it provides all the features
we currently have need of, and it available in the places we care about:

- debian/stable (bookworm): 3.11
- ubuntu/LTS (focal): 3.8
- emsdk: 3.9.2

Replaces: emscripten-core#23378
Fixes: emscripten-core#23387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update min python version from 3.6 to 3.8 sbc100/emscripten
1 participant
@sbc100