Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify terminology for "repository" #227

Closed
nbarnwell opened this issue May 9, 2024 · 3 comments
Closed

Clarify terminology for "repository" #227

nbarnwell opened this issue May 9, 2024 · 3 comments

Comments

@nbarnwell
Copy link

nbarnwell commented May 9, 2024

Hello, me again. I'm just wondering, before I make a mistake, what this project means when the word "repository" is used?

Is it expected to mean:

  1. The git repository that the ADRs are being stored in (i.e. the folder containing the .git folder)?
  2. The folder containing the ADRs (bearing in mind it's possible to provide a path to almost anywhere within the working copy when creating new ADRs)?

My confusion comes from https://github.com/endjin/dotnet-adr/blob/main/Solutions/Endjin.Adr.Cli.Specs/Features/Init.feature, which I think makes it sound like "an ADR repository within a source code repository". But then, with that said, I don't see anywhere that actually creates a readme.md, so I can't tell if that is meant to go in the root of the git repo, or in the docs/adr folder?

@HowardvanRooijen
Copy link
Member

Hey! Sorry for the delay. Gotta love overused terms! Yes adr repository is meant to signify whatever folder structure you create to contain the documents. I think the idea to have sensible defaults (or strong opinions weakly held) i.e. docs/adr which can easily be overridden or configured based on your org / team engineering practices / coding conventions.

The original motivation for creating this tool was that all the existing ADR tools were far too much "strong opinions, codified" for example there was only a single template and it was hard coded into the script / tool. I wanted people to adopt the process, but tailor it to their needs / existing processes / conventions / standard / repo structure.

Even across our own OSS estate we have a few different configurations:

And it wasn't until I published v1.0 that the notion that someone wouldn't want to build a nuget package to container their custom template, and instead they would want to point to a template within the adr repository.... 🤦

@HowardvanRooijen
Copy link
Member

Oh and #228 lists a bunch of other good ideas that hadn't occurred to me, which dovetails into your mention of a readme.md...

@nbarnwell
Copy link
Author

Question answered, thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants