Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Support for LaunchPad MSP430F5529 #285

Closed
RobLewis opened this issue Nov 8, 2013 · 6 comments
Closed

Improve Support for LaunchPad MSP430F5529 #285

RobLewis opened this issue Nov 8, 2013 · 6 comments

Comments

@RobLewis
Copy link

RobLewis commented Nov 8, 2013

According to its quickstart guide, some of the pin assignments on the Booster Pack connectors are different from other MSP430s (e.g., the I2C).

@measley
Copy link

measley commented Nov 8, 2013

Yes that's right, the 5529 is featuring a more robust pin mapping so that its easier to interact with multiple BoosterPacks. This is following that standards that are posted on ti.com. It's better to use these updated pin assignments for future proofing.

@astuder
Copy link

astuder commented Nov 11, 2013

For I2C I suggest to add setModule() to the TwoWire class, compatible with the implementation for Tiva/Stellaris.
https://github.com/energia/Energia/blob/master/hardware/lm4f/libraries/Wire/Wire.h

@rei-vilo
Copy link
Member

Same request for Serial1 on P3_4 P3_3 and SPI1 on P4_3 P4_2 P4_1 P4_0.

Now, wouldn't be easier to have Wire1 instead of setModule(1)?

That's the way taken with SPI0, SPI1, SPI2 = SPI (default) and SPI3 for the Stellaris LaunchPad on pending commit #256 answering issues #246 and #255.

@ghost ghost assigned robertinant Nov 13, 2013
@rei-vilo
Copy link
Member

Also to be considered:

@astuder
Copy link

astuder commented Nov 13, 2013

Re Wire1/SPI0-2: Is this referring to static, pre-initialized instances of the respective classes? If so, I'd be concerned about wasted memory when not in use. Defining the module as parameter of the constructor would make more sense.

@RobLewis
Copy link
Author

I don't know if this is the best place to note this, but in a couple of the libraries I've had to edit the
#if defined(…)
statement to add the F5529 to the list of supported parts.
The ones I'm using are for the BMP085 barometry sensor and the DHT22 humidity sensor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants