Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Page cache #1536

Open
rymsha opened this issue Dec 13, 2024 · 4 comments
Open

Remove Page cache #1536

rymsha opened this issue Dec 13, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@rymsha
Copy link
Contributor

rymsha commented Dec 13, 2024

Page cache is a workaround for a bug enonic/xp#10800

@rymsha rymsha added the enhancement New feature or request label Dec 13, 2024
@ComLock
Copy link
Contributor

ComLock commented Dec 16, 2024

As a side note there are currently 6 caches in lib-react4xp:
https://github.com/search?q=repo%3Aenonic%2Flib-react4xp%20newCache(&type=code

@rymsha
Copy link
Contributor Author

rymsha commented Dec 16, 2024

I guess we are talking about 3 here templateDescriptorCache.ts, contentTypeToPageComponentCache.ts, pageTemplateContentIdToPageComponentCache.ts

@rymsha
Copy link
Contributor Author

rymsha commented Jan 15, 2025

enonic/xp#10800 fixed issue with unresolved page templates. all 3 caches are used in workarounds.
They are actually buggy:

  • they break experience in development - as for 10 minutes changes they cache won't be seen
  • templateDescriptorCache does not take into account that application of descriptor can be from a different app, but with the same name
  • regions are not correctly realigned according to descriptors

@rymsha
Copy link
Contributor Author

rymsha commented Jan 15, 2025

also enonic/xp#10116 - no need to check for null for fragments path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants