Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full client-side rendering of regions that contain components that need page contributions to work #38

Open
espen42 opened this issue Feb 8, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@espen42
Copy link
Contributor

espen42 commented Feb 8, 2020

When React4xp client-side renders a region, a second rendering step is inserted by the client (postfillRegions). This can fetch and insert rendered HTML for the XP components that are contained in the region.

But not their page contributions. Currently, it's not possible in XP to fetch a particular component's page contributions from the client side (and it's provent fairly difficult to build a custom service for it) - only the HTML.

This means:

  • It's possible for React4xp to server-side render entries with <Regions> and have the XP components get the page contributions they need (e.g. client-side rendered React4xp entries etc),
  • Vice versa: It's possible to client-side render <Regions> as long as they don't contain XP components that need page contributions,
  • But the combination - client-side rendering that contain anything that needs page contributions, will fail. This includes React4xp entries in the regions unless they are server-side rendered and ONLY needs the HTML - i.e. don't need any react hydration or other client-side activation.
@espen42 espen42 added the enhancement New feature or request label Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant