Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content hashes must be prefixed by 0x #45

Open
cobordism opened this issue Apr 25, 2018 · 3 comments
Open

Content hashes must be prefixed by 0x #45

cobordism opened this issue Apr 25, 2018 · 3 comments

Comments

@cobordism
Copy link

When registering a swarm content hash as the content in the default resolver I have to manually insert 0x in front of the swarm hash in order for it to work.

This is a nuisance that many people (in swarm support channel) have tripped over this past year.
It would be great if manager.ens.domains could correctly handle swarm hashes without the 0x prefix or at least display an appropriate warning.

@vinniejames
Copy link

vinniejames commented Nov 17, 2018

I'm curious if this affect IPFS hashes as well? I've tried several times to set the content hash for IPFS to my .eth domain. If I submit the tx with as simply 1hash, without 0x, the tx succeeds, but my domain resolves to the wrong hash in the Status browser on ipfs.infura.io

Attempting to submit the transaction as 0x1hash results in MetaMask jumping gas to $4, and produces an error ALERT: Transaction Error. Exception thrown in contract code.

The site is available directly, via Infura

How do I successfully map my .eth domain to IPFS?

@adamskrodzki
Copy link

I'm strugelling with same problem, I've tried
set
QmRL6bs8yPQC3qy6pz711Ezfds9fKUb66NVE1iByyqt7DD
directly

and in binary form
0x2c6ec1afca38256bfe15f4626dc4775a014827742851c4fae0a49e6a35628994
both fails

the thing is probably related to incorrect content resolver
0xD3ddcCDD3b25A8a7423B5bEe360a42146eb4Baf3
instead of
0x1da022710df5002339274aadee8d58218e9d6ab5

with different function names

@cobordism
Copy link
Author

Correct.
The resolver at 0xD3ddcCDD3b25A8a7423B5bEe360a42146eb4Baf3 is a new one, in line with https://eips.ethereum.org/EIPS/eip-1577 and it does not work with the manager app.

This is the correct resolver to use for now
0x1da022710df5002339274aadee8d58218e9d6ab5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants