Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redesign] Windows are closed automatically if to click outside the window. We want to allow the windows to be closed on X only. #1918

Closed
1 task done
VolhaBazhkova opened this issue Aug 12, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@VolhaBazhkova
Copy link

VolhaBazhkova commented Aug 12, 2024

EPAM AI DIAL chat version

0.16.0

What happened?

Now all pop-up windows are closed if to click out side of them.
For example, while publication request there could be an error. If to close the error on 'x', clickoutside action is triggered and publication window is closed automatically. It confuses as user has to start publication from the beginning.

Example:
https://github.com/user-attachments/assets/aa46ef23-2ca8-4647-8bba-c5b1db9498c1

Expected: We want to allow pop-ups to be closed on X only, need to forbid to close the pop-up automatically on clicking outside the window. No need to do this for any confirmation pop-ups.

Confidential information

  • I confirm that do not share any confidential information
@VolhaBazhkova VolhaBazhkova added the bug Something isn't working label Aug 12, 2024
@IlyaBondar
Copy link
Collaborator

Note: I suggest to add ignoreParentClass into Modal-component and pass outsidePress into useDismiss

@VolhaBazhkova
Copy link
Author

Discussed on daily and we decided to update the ticket:
initial problem: Windows are closed automatically if to close the error on 'x'. Example, with publish and unpublish window.
decided to fix it: We want to allow pop-ups to be closed on X only, need to forbid to close the pop-up automatically on clicking outside the window.

@VolhaBazhkova VolhaBazhkova added enhancement New feature or request and removed bug Something isn't working labels Aug 13, 2024
@VolhaBazhkova VolhaBazhkova changed the title Windows are closed automatically if to close the error on 'x'. Example, with publish and unpublish window. [Redesign] Windows are closed automatically if to click outside the window. We want to allow the windows to be closed on X only. Aug 13, 2024
@denys-kolomiitsev denys-kolomiitsev self-assigned this Aug 22, 2024
@denys-kolomiitsev denys-kolomiitsev moved this to In Progress in AI DIAL Aug 22, 2024
@VolhaBazhkova
Copy link
Author

Verified on staging env successfully.
The following forms can be closed now on 'X' or Cancel buttons only. They remain on the screen if to click on any area outside the windows:

  • Request API Key
  • Report an issue
  • Conversation settings
  • Publish
  • Unpublish
  • Add application
  • Edit prompt

All other confirmations and some windows where user doesn't need to type any info manually can be closed automatically on the click outside. For example:

  • Chat, Chat history or Prompt confirmations while deleting/clearing
  • Talk to (See full list)
  • See all addons
  • Manage attachments, Attach files, Attach folders, Attach links
  • Upload from device
  • Share
  • Unshare

@github-project-automation github-project-automation bot moved this from In Testing to Done in AI DIAL Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants