feat: Calculate token usage statistics using call stack #117 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| callInfo.childSpanIds.add(childSpanId); | ||
| } | ||
|
|
||
| public synchronized void setTokeUsage(String spanId, TokenUsage tokenUsage) { |
There was a problem hiding this comment.
Please correct type: setTokenUsage
| public void calculateTokenUsage(ProxyContext context) { | ||
| Entity entity = getEntityFromTracingContext(context); | ||
| if (entity == null) { | ||
| log.warn("Entity is not found by traceId={}", context.getTraceId()); |
There was a problem hiding this comment.
Please add prefix to locate the problem more easily: "Failed to calculate token usage"
| public synchronized void link(String parentSpanId, String childSpanId) { | ||
| CallInfo callInfo = spanIdToCallInfo.get(parentSpanId); | ||
| if (callInfo == null) { | ||
| log.warn("Parent span is not found by id: {}", parentSpanId); |
There was a problem hiding this comment.
Please improve logging in this class.
| log.warn("Entity is not found by traceId={}", context.getTraceId()); | ||
| return; | ||
| } | ||
| context.setTokenUsage(entity.calculate(context.getCurrentSpanId())); |
There was a problem hiding this comment.
Is it better to do it only if it is missing? Some applications/models can compute it more precisely.
There was a problem hiding this comment.
We can rely on applications/assistants any longer to compute statistics
| private final List<String> roles; | ||
| private final String name; | ||
| private final boolean user; | ||
| private final Map<String, CallInfo> spanIdToCallInfo = new HashMap<>(); |
There was a problem hiding this comment.
Please move the logic related to token tracking to a separate class. e.g. TokenTracker
|
no longer valid since the core is moved to per request key authorization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.