Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autotests: Connection rules tests refactoring #6213

Closed
6 of 7 tasks
AlexeyGirin opened this issue Dec 25, 2024 · 0 comments · Fixed by #6256
Closed
6 of 7 tasks

Autotests: Connection rules tests refactoring #6213

AlexeyGirin opened this issue Dec 25, 2024 · 0 comments · Fixed by #6256
Labels
Autotests refactor Code refactoring, without changing the functionality
Milestone
Autotests

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Dec 25, 2024 •
edited
Loading

Background
Connection rules has following disadvantages:

  1. Each bunch uses local (often identical) helper functions that are not universal
  2. Each test uses screenshots for assertion
  3. Slightly unstable since known problem with the canvas (canvas shift, label shift problems)

Solution

  1. Create universal helper functions (that uses advances of data-* attributes)
  2. Replace screenshots for asserts with precise assert for each check

Scope

  • Base - 322 tests
    Execution time before: 3.6m
    Execution time after: 3.2m
  • CHEM - 724 tests
    Execution time before: 8.7m
    Execution time after: 7.6m
  • Nucleotide - 1076 tests
    Execution time before: 12.6m
    Execution time after: 9.0m
  • Peptides - 724 tests
    Execution time before: 8.2m
    Execution time after: 6.9m
  • Phosphate - 266 tests
    Execution time before: 3.2m
    Execution time after: 2.7m
  • RNA - 60 tests
    Execution time before: 57.6s
    Execution time after:
  • Sugar - 736 tests
    Execution time before: 8.1m
    Execution time after: 6.4m

Total: 3908 tests
Execution time before: 45.4m
Execution time after:
@AlexeyGirin AlexeyGirin added this to the Autotests milestone Dec 25, 2024
@AlexeyGirin AlexeyGirin added refactor Code refactoring, without changing the functionality and removed technical debt labels Dec 25, 2024
@AlexeyGirin AlexeyGirin linked a pull request Jan 11, 2025 that will close this issue
Autotests: #6213 - autotests connection rules tests refactoring #6256
Merged
9 tasks
AlexeyGirin added a commit that referenced this issue Jan 14, 2025
@AlexeyGirin @svvald @knadonenko
Autotests: #6213 - autotests connection rules tests refactoring (#6256)
25e5558 
* first draft

* Base to base done

* Case5 done

* Case6 done

* Test case8 done

* Case 9 done

* connection-rules-for-base-monomers.spec are done

* CHEMS: Case 1 done

* Case 2 done

* Case 3 done

* Case 4 done

* Test case5 done

* Test case6 done

* Case 7 done

* Case 8 done

* Test case9 done

* Case 10 done

* Final of CHEM

* Ok, that is final

* Nucleotides - Test case1 done

* Test case2 done

* Case3 done

* Case4 done

* Case5 done

* Case6 done

* Test case7 done

* Case 8 done

* Case9 and Case10 are done

* Case11 done

* Case12 done

* Case13 done

* Case14 done

* Nucleotides are done

* This is final

* Peptides: Case 1 and Case 2 are done

* Case 3 done

* Case 5 done

* Case 6 done

* Case 7 done

* Case 8 done

* Case 9 and Case 10 done

* Final Peptides

* Phosphate - Test case1 and Test case2 are done

* Case3 done

* Case4 done

* Case5 and Case6 done

* Test case9 done

* Phosphate are done

* sugar - Case 1 done

* Case6 done

* Case7 done

* Case9 done

* Case8 done

* Test case9 and Case 10 are done

* Sugar is done

* final 2

* Final 3

* Final 4

* 5

* Last fix

* polymer-bond-tool fix

* Fix roll back

* Backmerge: #6235 – Incorrect representation of hydrogens for alias charge valence and radical properties in macro mode (#6262)

* Autotests: #6043 - autotests replace file comparison for cdxml files only operations with valid helper functions verifyfileexport (#6260)

* refactoring

* refactoring

* Final 3

* Final 4

* 5

* Final 3

* Final 4

* 5

* data attribudetes added

* Fix for atoms added

* Last fix

* Last last fix

---------

Co-authored-by: Nikita Chistousov <[email protected]>
Co-authored-by: Konstantin <[email protected]>
AlexeyGirin added a commit that referenced this issue Jan 14, 2025
@AlexeyGirin @svvald @knadonenko
Autotests: #6213 - autotests connection rules tests refactoring (#6256)
de01c3e 
* first draft

* Base to base done

* Case5 done

* Case6 done

* Test case8 done

* Case 9 done

* connection-rules-for-base-monomers.spec are done

* CHEMS: Case 1 done

* Case 2 done

* Case 3 done

* Case 4 done

* Test case5 done

* Test case6 done

* Case 7 done

* Case 8 done

* Test case9 done

* Case 10 done

* Final of CHEM

* Ok, that is final

* Nucleotides - Test case1 done

* Test case2 done

* Case3 done

* Case4 done

* Case5 done

* Case6 done

* Test case7 done

* Case 8 done

* Case9 and Case10 are done

* Case11 done

* Case12 done

* Case13 done

* Case14 done

* Nucleotides are done

* This is final

* Peptides: Case 1 and Case 2 are done

* Case 3 done

* Case 5 done

* Case 6 done

* Case 7 done

* Case 8 done

* Case 9 and Case 10 done

* Final Peptides

* Phosphate - Test case1 and Test case2 are done

* Case3 done

* Case4 done

* Case5 and Case6 done

* Test case9 done

* Phosphate are done

* sugar - Case 1 done

* Case6 done

* Case7 done

* Case9 done

* Case8 done

* Test case9 and Case 10 are done

* Sugar is done

* final 2

* Final 3

* Final 4

* 5

* Last fix

* polymer-bond-tool fix

* Fix roll back

* Backmerge: #6235 – Incorrect representation of hydrogens for alias charge valence and radical properties in macro mode (#6262)

* Autotests: #6043 - autotests replace file comparison for cdxml files only operations with valid helper functions verifyfileexport (#6260)

* refactoring

* refactoring

* Final 3

* Final 4

* 5

* Final 3

* Final 4

* 5

* data attribudetes added

* Fix for atoms added

* Last fix

* Last last fix

---------

Co-authored-by: Nikita Chistousov <[email protected]>
Co-authored-by: Konstantin <[email protected]>
AlexeyGirin added a commit that referenced this issue Jan 14, 2025
@kostrubin @YatsekTest
@svvald @knadonenko @Drimodaren @AlexeyGirin
#5995 - Synchronize the library tab with typing type switcher in sequ…
a153265 
…ence mode (#6251)

* #5995 - Synchronize the library tab with typing type switcher in sequence mode

* SMARTS files comparison code have been replaced with the appropiate helper function (verifyFileExport()). (#6253)

* Backmerge: #6235 – Incorrect representation of hydrogens for alias charge valence and radical properties in macro mode (#6262)

* Autotests: #6043 - autotests replace file comparison for cdxml files only operations with valid helper functions verifyfileexport (#6260)

* refactoring

* refactoring

* 6108-system-allow-to-select-monomers-behind-opened-context-menu (#6261)

Co-authored-by: Andrey Menshikov <[email protected]>

* Autotests: #6213 - autotests connection rules tests refactoring (#6256)

* first draft

* Base to base done

* Case5 done

* Case6 done

* Test case8 done

* Case 9 done

* connection-rules-for-base-monomers.spec are done

* CHEMS: Case 1 done

* Case 2 done

* Case 3 done

* Case 4 done

* Test case5 done

* Test case6 done

* Case 7 done

* Case 8 done

* Test case9 done

* Case 10 done

* Final of CHEM

* Ok, that is final

* Nucleotides - Test case1 done

* Test case2 done

* Case3 done

* Case4 done

* Case5 done

* Case6 done

* Test case7 done

* Case 8 done

* Case9 and Case10 are done

* Case11 done

* Case12 done

* Case13 done

* Case14 done

* Nucleotides are done

* This is final

* Peptides: Case 1 and Case 2 are done

* Case 3 done

* Case 5 done

* Case 6 done

* Case 7 done

* Case 8 done

* Case 9 and Case 10 done

* Final Peptides

* Phosphate - Test case1 and Test case2 are done

* Case3 done

* Case4 done

* Case5 and Case6 done

* Test case9 done

* Phosphate are done

* sugar - Case 1 done

* Case6 done

* Case7 done

* Case9 done

* Case8 done

* Test case9 and Case 10 are done

* Sugar is done

* final 2

* Final 3

* Final 4

* 5

* Last fix

* polymer-bond-tool fix

* Fix roll back

* Backmerge: #6235 – Incorrect representation of hydrogens for alias charge valence and radical properties in macro mode (#6262)

* Autotests: #6043 - autotests replace file comparison for cdxml files only operations with valid helper functions verifyfileexport (#6260)

* refactoring

* refactoring

* Final 3

* Final 4

* 5

* Final 3

* Final 4

* 5

* data attribudetes added

* Fix for atoms added

* Last fix

* Last last fix

---------

Co-authored-by: Nikita Chistousov <[email protected]>
Co-authored-by: Konstantin <[email protected]>

* import-saving-idt.spec.ts updated

* import-saving-idt.spec.ts done

* Ultimate solution

* Final fix

---------

Co-authored-by: Yaroslav Kovalsky <[email protected]>
Co-authored-by: Nikita Chistousov <[email protected]>
Co-authored-by: Konstantin <[email protected]>
Co-authored-by: Anrei Menshikov <[email protected]>
Co-authored-by: Andrey Menshikov <[email protected]>
Co-authored-by: Alexey Girin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Autotests refactor Code refactoring, without changing the functionality
Projects
None yet
Milestone
Autotests
Development

Successfully merging a pull request may close this issue.

Autotests: #6213 - autotests connection rules tests refactoring epam/ketcher
1 participant
@AlexeyGirin