From 5acc74682ddc5efdf731a30d04dede9a23c6db79 Mon Sep 17 00:00:00 2001
From: Felix Rindt <felix@rindt.me>
Date: Thu, 12 Dec 2024 13:13:45 +0100
Subject: [PATCH] fix event change permission check

---
 ephios/core/templates/core/event_detail.html | 5 +----
 ephios/core/views/event.py                   | 6 ++++++
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/ephios/core/templates/core/event_detail.html b/ephios/core/templates/core/event_detail.html
index e300c9c10..8ba5d6bb0 100644
--- a/ephios/core/templates/core/event_detail.html
+++ b/ephios/core/templates/core/event_detail.html
@@ -20,9 +20,6 @@
 {% endblock %}
 
 {% block content %}
-    {% if request.user.is_authenticated %}
-        {% get_obj_perms request.user for event as "event_perms" %}
-    {% endif %}
     {% if not event.active %}
         {% if event.shifts.exists %}
             {% translate "This event has not been saved! If you are done editing the event, you can save it." as not_active_error %}
@@ -40,7 +37,7 @@
     <div class="card mb-3">
         <div class="card-body pb-0">
             <h1 class="card-title fw-bold fs-1">
-                {% if "change_event" in event_perms %}
+                {% if can_change_event %}
                     <div class="dropstart float-end">
                         <button class="btn" type="button" id="actionDropdownButton"
                                 data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
diff --git a/ephios/core/views/event.py b/ephios/core/views/event.py
index f7d2555ba..d9bef35fa 100644
--- a/ephios/core/views/event.py
+++ b/ephios/core/views/event.py
@@ -450,6 +450,12 @@ def get_queryset(self):
             base = Event.all_objects.all()
         return base.prefetch_related("shifts", "shifts__participations")
 
+    def get_context_data(self, **kwargs):
+        kwargs["can_change_event"] = self.object in get_objects_for_user(
+            self.request.user, "core.change_event"
+        )
+        return super().get_context_data(**kwargs)
+
 
 class EventUpdateView(CustomPermissionRequiredMixin, PluginFormMixin, UpdateView):
     model = Event