Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notification and banner feature #1836

Open
Eddasol opened this issue Nov 29, 2024 · 1 comment
Open

Improve notification and banner feature #1836

Eddasol opened this issue Nov 29, 2024 · 1 comment
Labels
improvement Improvement to existing functionality ux Issue needs input from UX designer

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Nov 29, 2024

Describe the improvement you would like to see
Currently notification (the bell in the header) and banner features are duplicates of each other. Suggested new solution is that banner will handle information that is relevant for the user while using flotilla, like if a mission fails to get scheduled. Notifications should be use for things that occur when the user might not be actively using flotilla that is use full to know when checking at a later time.

Notification should:

  • Have timestamp and show newest first
  • Should have these kind of notifications:
    • Failed missions
    • Aborted mission. Eg. If safe zone gets activated during mission or robot health (like low battery) causing the mission to be aborted

Banner should:

  • Only be used for things that happened now because of something the user did or something that is actively happening
  • Should either: Not overwrite each other OR have such generic text that it doesn't matter that they overwrite each other
    • Example: If failing to schedule 2 missions only the last to fail will get banner as the first gets overwritten. Either have several or a generic enough message
  • Should have these kind of banners:
    • "Send to dock" being active and robots being released from dock
    • Failing to schedule a mission
    • Failure to fetch requested info (like echo missions or should this always be handled as a popup or something instead?)

Currently we have these alert types:
MissionFail -> Should be notification (should also partially successful give alert?)
RequestFail -> Should be banner
DockFail -> Is this a failed mission? Might be both banner and notification if the robot gets stuck in the field and require assistance
BlockedRobot -> Remove? Isar is no longer providing this information
RequestDock -> Should be banner (if aborting a mission because of this it will get covered by mission fail as well)
DismissDock -> Should be banner
DockSuccess -> Should be banner

TODO:

  1. Remove existing notifications (not banners)
  2. Implement notification for failed missions with timestamp, sorted by newest first
  3. Remove banner for failed missions

How will this change existing functionality?

How will this improvement affect the current Threat Model?

@Eddasol Eddasol added improvement Improvement to existing functionality epic and removed epic labels Nov 29, 2024
@Eddasol
Copy link
Contributor Author

Eddasol commented Nov 29, 2024

Recommend checking #1592 for additional information

@tsundvoll tsundvoll added the ux Issue needs input from UX designer label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality ux Issue needs input from UX designer
Projects
None yet
Development

No branches or pull requests

2 participants