Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce synchronous sign? #63

Open
oyooyo opened this issue Aug 18, 2022 · 2 comments
Open

Introduce synchronous sign? #63

oyooyo opened this issue Aug 18, 2022 · 2 comments

Comments

@oyooyo
Copy link

oyooyo commented Aug 18, 2022

I would like to also have a synchronous createSync() version of sign.create()

In #47, @JesusMcCloud already suggested synchronous createSync() and verifySync() functions, but apparently only verifySync() was actually introduced.

Is there a good reason for that, or was createSync() simply forgotten?
@JesusMcCloud
Copy link
Contributor

Odd… the original MR has the export added. see: e75fea3#diff-02346278010f5099e4be2cae18e3a443e44892be47996d75abf55602e0349b8bR62

@erdtman
Copy link
Owner

erdtman commented Sep 14, 2023

It was a long time ago, but I think I ran into problems with large payloads and the sync cbor functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erdtman @JesusMcCloud @oyooyo