Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adblock in CC #502

Open
obsy opened this issue Mar 16, 2016 · 4 comments
Open

adblock in CC #502

obsy opened this issue Mar 16, 2016 · 4 comments

Comments

@obsy
Copy link
Contributor

obsy commented Mar 16, 2016

Now we have adblock in CC (openwrt/packages@081f255).

Did you consider supporting this package in plugin-gargoyle-adblock?

@lantis1008
Copy link
Contributor

That package is really bloated. Don't get me wrong it's a good
implementation, but it's over the top for what it is. I don't think you
really need a daemon running looking for updates or anything, the lists
just aren't that frequent.
His auto setup of interfaces is nice though.

Did you have anything in particular you wanted from it?

On 17 Mar 2016, at 4:05 AM, Cezary Jackiewicz [email protected]
wrote:

Now we have adblock in CC (openwrt/packages@081f255
openwrt/packages@081f255).

Did you consider supporting this package in plugin-gargoyle-adblock?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#502

@obsy
Copy link
Contributor Author

obsy commented Mar 16, 2016

Keep those same solutions without duplicating packages/functionality.

@lantis1008
Copy link
Contributor

I guess so.
I like his firewall implementation better then mine, but it won't play nicely with gargoyle I don't think.

If people think it's worth doing I'll look but I'm not keen.

@ericpaulbishop
Copy link
Owner

I would be open to having multiple packages with an adblock solution, one that is the old way, one with the new package if you want to create a new plugin based on the openwrt package.

That said, given that Lantis built and is maintaining that plugin, and it isn't part of the core set of packages, I'm going to go with whatever he wants to do for his plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants