Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't submit function signature "mint(uint256 nonce, bytes32 challenge_digest)" to the directory #28

Closed
smarx opened this issue Jun 11, 2018 · 7 comments

Comments

@smarx
Copy link

smarx commented Jun 11, 2018

I thought I'd help out by submitting signatures some hashes in #25 (comment).

I tried via https://www.4byte.directory/submit/ to submit the signature mint(uint256 nonce, bytes32 challenge_digest), but it seems to have been misinterpreted as mint(int256,uint256,bytes32). My guess without reading code is that the "int" in "mint" was misinterpreted as a parameter.

@ligi
Copy link
Member

ligi commented Jun 11, 2018

thanks for the hint - cc @pipermerriam

@smarx
Copy link
Author

smarx commented Jun 11, 2018

FYI, perhaps the same problem with mint(address _to, uint256 _amount). (Not 100% sure how this one was interpreted because I just got a 500.) This is also in the "top 20" list.

@ligi
Copy link
Member

ligi commented Jun 11, 2018

yea also getting 500 now - might be more instances of this: pipermerriam/ethereum-function-signature-registry#30
Maybe I make a separate backend soon to decouple from this python stuff ;-)

@smarx
Copy link
Author

smarx commented Jun 11, 2018

Ah, I couldn't find the repo for the website. Should I open an issue over there so we can close this one?

@ligi
Copy link
Member

ligi commented Jun 11, 2018

that would be great!

@smarx
Copy link
Author

smarx commented Jun 11, 2018

@smarx smarx closed this as completed Jun 11, 2018
ligi added a commit that referenced this issue Jun 12, 2018
@pipermerriam
Copy link

Should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants