Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading comments in test filler #1407

Closed
xrchz opened this issue Oct 18, 2024 · 2 comments
Closed

Misleading comments in test filler #1407

xrchz opened this issue Oct 18, 2024 · 2 comments

Comments

@xrchz
Copy link

xrchz commented Oct 18, 2024

tests/src/GeneralStateTestsFiller/VMTests/vmTests/calldatacopyFiller.yml

Line 171 in 9201075

; Put a 0x10 byte long value in zero (each byte is two hex digits)

The comments claim a 0x10 byte long value is going into memory, but then the value is 0x11 bytes. I think this may be related to another misleading comment earlier that says an mload should produce 0 when it in fact produces 0x12.
@winsvega
Copy link
Collaborator

winsvega commented Nov 5, 2024

feel free to correct

@DavidRomanovizc DavidRomanovizc mentioned this issue Nov 6, 2024
Closed
@winsvega
Copy link
Collaborator

wait but then you changed the call argument and the test have no notice.
it means poor checks are done in the tests. so you changed the argument by 1 and it didn't affect anything in verification logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct comments DavidRomanovizc/tests
2 participants
@xrchz @winsvega