From 3b10c20e34df5c71fc8d706af12bb142ff749dec Mon Sep 17 00:00:00 2001 From: Barinade Date: Sun, 13 Mar 2022 16:10:22 -0500 Subject: [PATCH] remove the ability to hold start to go to eval after practice --- src/Etterna/Screen/Gameplay/ScreenGameplay.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Etterna/Screen/Gameplay/ScreenGameplay.cpp b/src/Etterna/Screen/Gameplay/ScreenGameplay.cpp index 128bd22e3d..0906a3983c 100644 --- a/src/Etterna/Screen/Gameplay/ScreenGameplay.cpp +++ b/src/Etterna/Screen/Gameplay/ScreenGameplay.cpp @@ -1309,8 +1309,10 @@ ScreenGameplay::Input(const InputEventPlus& input) -> bool bHoldingGiveUp |= (input.MenuI == GAME_BUTTON_START); } - // Exiting gameplay by holding Start (Forced Fail) - if (bHoldingGiveUp && PREFSMAN->m_AllowStartToGiveUp) { + // Exiting gameplay by holding Start (Forced Fail) + // Never allow holding start in Practice Mode + if (bHoldingGiveUp && !GAMESTATE->IsPracticeMode() && + PREFSMAN->m_AllowStartToGiveUp) { if (input.type == IET_RELEASE) { AbortGiveUp(true); } else if (input.type == IET_FIRST_PRESS &&