From 6b32ed73ca3a451486fcce55edb2b53656eec60a Mon Sep 17 00:00:00 2001 From: Nicolas Date: Thu, 14 May 2020 09:23:55 -0300 Subject: [PATCH] Fix deref-before-null-check coverity defect --- src/RageUtil/Graphics/RageDisplay_OGL.cpp | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/RageUtil/Graphics/RageDisplay_OGL.cpp b/src/RageUtil/Graphics/RageDisplay_OGL.cpp index 73fd3083d3..05dc26f7d4 100644 --- a/src/RageUtil/Graphics/RageDisplay_OGL.cpp +++ b/src/RageUtil/Graphics/RageDisplay_OGL.cpp @@ -2775,15 +2775,16 @@ RageDisplay_Legacy::CreateRenderTarget(const RenderTargetParam& param, pTarget = new RenderTarget_FramebufferObject; else pTarget = g_pWind->CreateRenderTarget(); - - pTarget->Create(param, iTextureWidthOut, iTextureHeightOut); - - intptr_t iTexture = pTarget->GetTexture(); - - ASSERT(g_mapRenderTargets.find(iTexture) == g_mapRenderTargets.end()); - if (pTarget) + + if (pTarget) { + pTarget->Create(param, iTextureWidthOut, iTextureHeightOut); + + intptr_t iTexture = pTarget->GetTexture(); + + ASSERT(g_mapRenderTargets.find(iTexture) == g_mapRenderTargets.end()); g_mapRenderTargets[iTexture] = pTarget; - + } + return iTexture; }