Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

float_source matlab files incorrect #73

Closed
gmaze opened this issue Nov 8, 2021 · 2 comments
Closed

float_source matlab files incorrect #73

gmaze opened this issue Nov 8, 2021 · 2 comments
Labels
invalid This doesn't seem right

Comments

@gmaze
Copy link
Member

gmaze commented Nov 8, 2021

While working on euroargodev/argopy/issues/141 and euroargodev/argopy/pull/142 I found that the following pyowc float_source matlab files:

are incorrect !

They appear to have been generated with an old version of the Matlab routine create_float_source.m.
The last version uses another method to sub-select vertical pressure levels (floor instead of round),
It can be seen here: euroargodev/dm_floats@7497874#diff-a7f153565065c547918a043959d1efd54b042a8d75edbf7fcef1c8bd6f76ec72

So I guess these files must be updated
The most recent version of the create_float_source.m routine is here:
https://github.com/euroargodev/dm_floats/blob/master/src/ow_source/create_float_source.m

@gmaze gmaze added the invalid This doesn't seem right label Nov 8, 2021
@kamwal
Copy link
Contributor

kamwal commented Oct 25, 2022

yes, we used the previous version of the float_source code. I am going to regenerate this file and update the example in the branch

@kamwal
Copy link
Contributor

kamwal commented Nov 7, 2022

the source data and source data have been updated using the new routine
https://github.com/euroargodev/dm_floats/blob/master/src/ow_source/create_float_source.m

@kamwal kamwal closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants