Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prevent future bugs #19

Open
evanpacini opened this issue Jun 9, 2023 · 2 comments
Open

refactor: prevent future bugs #19

evanpacini opened this issue Jun 9, 2023 · 2 comments
Assignees
Labels
help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested

Comments

@evanpacini
Copy link
Owner

Error handling is not implemented properly everywhere. While memory allocation errors are always logged and return NULL, the functions that actually use them don't necessarily handle NULL properly.

@evanpacini evanpacini added the invalid This doesn't seem right label Jun 9, 2023
@evanpacini evanpacini self-assigned this Jun 9, 2023
@evanpacini evanpacini added help wanted Extra attention is needed question Further information is requested labels Jun 13, 2023
@evanpacini
Copy link
Owner Author

I am actually unsure whether I should implement each function to have pre-condition checks or have the user check for those.

@KaspervanM
Copy link
Collaborator

I am keen to say having pre-condition checks is best, but I think that depends on how they would be used in the end. If only another interface (for the python program) interacts with the functions, then perhaps having that interface deal with the pre- and post-condition checks is preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants