Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add session passing to functions #5

Open
samdixon opened this issue Oct 17, 2019 · 1 comment
Open

Feature Request: Add session passing to functions #5

samdixon opened this issue Oct 17, 2019 · 1 comment

Comments

@samdixon
Copy link

Hey Joachim,

Thanks for the module, I have been using it to build out a utility to allow me to easily search and copy my bitwarden passwords to clipboard with fzf for search.

I ran into a small issue while using the module where I want to built a username/password cache using the bw() function, then using those results I call the get_password() func. The issue I am having is it is repeatedly calling for a new session on each function call (which asks me for password each time to unlock), and there doesn't seem to be a way to pass the session to the get_password, set_password, or del_password functions.

I am proposing the following, add a function input session=None, then add a small check inside the function. If session == None, it will grab the session from users password, else it will use the session passed to it.

I have created #4 with the additions, tests, and minor version bump. Wanted to write my thoughts out here as well.

Let me know if you know a better way.

  • Sam
@ewjoachim
Copy link
Owner

Hey Sam!

I just realized I forgot to watch this repo. Sorry for the 2 year lag...

I'll review your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants