Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit cells are not fully supported #114

Open
avmarchenko opened this issue May 2, 2018 · 0 comments
Open

Unit cells are not fully supported #114

avmarchenko opened this issue May 2, 2018 · 0 comments
Labels
Enhancement Extend an existing feature Visualizations Feature requests related to visualization functionality

Comments

@avmarchenko
Copy link
Member

Currently only a simple cubic unit cell is displayed (if available). This is a complete hack and should be fixed. Relevant code is in exatomic/widgets/traits.py:frame_traits and js/src/appthree.js:add_unit_axis. There is a comment that says "Hack to also add unit..." (in that function) which is the place to start on the frontend side of things.

This code (and the Python code in traits.py) should be generalized to support an arbitrary cell and to support unique cells for every frame in a multiframe universe.

@tjduigna tjduigna added Visualizations Feature requests related to visualization functionality Enhancement Extend an existing feature labels Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Extend an existing feature Visualizations Feature requests related to visualization functionality
Projects
None yet
Development

No branches or pull requests

2 participants