Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different behavior for neighbors.periodic_nearest_neighbors_by_atom() and neighbors.periodic_nearest_neighbors_by_atom_large() #133

Open
adamphil opened this issue Dec 17, 2018 · 2 comments
Labels
Need more info More information is needed from OP

Comments

@adamphil
Copy link
Member

adamphil commented Dec 17, 2018

Using all the same arguments, some atoms are excluded when computing neighbors using the _large version of the function. Seems to have to do with the passing of kwargs regarding bond thresholds and molecule computation.

@avmarchenko
Copy link
Member

Thanks for this issue report. Would it be possible to give a minimal working example perhaps? Including the commands run and a snapshot (xyz or similar) where the behavior is observed would help debug. It is possible that there is a bug in the code or (more nefariously) that the algorithm has nuances that haven't been uncovered. Either way, the commands run and an example snapshot are necessary to investigate.

@tjduigna tjduigna added the Need more info More information is needed from OP label Dec 23, 2018
@adamphil
Copy link
Member Author

adamphil commented Dec 27, 2018

exatomic-issue#133.py.txt
example.txt

Don't think I did this properly but w/e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Need more info More information is needed from OP
Projects
None yet
Development

No branches or pull requests

3 participants