Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quirks of the travis build #136

Closed
tjduigna opened this issue Jan 5, 2019 · 4 comments
Closed

Quirks of the travis build #136

tjduigna opened this issue Jan 5, 2019 · 4 comments

Comments

@tjduigna
Copy link
Contributor

tjduigna commented Jan 5, 2019

Describe the bug
This is just a minor issue with the way the .travis.yml builds exatomic. When mimicking the installation, the command to pip install -e exa/ requires a pip install of the following packages:

Installing collected packages: scipy, networkx, kiwisolver, cycler, matplotlib, seaborn, exa
  Running setup.py develop for exa

To Reproduce
Steps to reproduce the behavior:

Run the commands in the .travis.yml starting from:

- conda create -n test python=$PYTHONVER

to

- pip install -e exa/

Expected behavior
I expected there to be no additional dependencies for pip to install when installing the git clone of exa.
We already enumerate explicitly the packages needed to cover the exa/tomic stack in the .travis.yml file anyway, so perhaps we should leverage conda to install the above dependencies not already picked up.

Desktop (please complete the following information):

Additional context
Thought it may be a suitable issue for exa instead. But since exa/tomic are tightly coupled, it makes sense that we directly git clone exa during the exatomic build. Therefore it may only pertain to the exatomic build directly.

@avmarchenko
Copy link
Member

This is a good catch. Like you write, one possible approach might be to modify the requirements.txt in exa. My gut reaction is that that is the most appropriate approach - a fix it at the source type approach. Waiting for others to weigh in.

@tjduigna
Copy link
Contributor Author

tjduigna commented Jan 5, 2019

May be a non-issue 😃 having trouble reproducing, it may have just been a conda installation fail. I will close this if I can't reproduce it.

@herbertludowieg
Copy link
Member

Just want to bump this.
Is it still an issue?

@tjduigna
Copy link
Contributor Author

tjduigna commented Nov 3, 2021

Closing in favor of #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants