-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quirks of the travis build #136
Comments
This is a good catch. Like you write, one possible approach might be to modify the |
May be a non-issue 😃 having trouble reproducing, it may have just been a conda installation fail. I will close this if I can't reproduce it. |
Just want to bump this. |
Closing in favor of #231 |
Describe the bug
This is just a minor issue with the way the .travis.yml builds exatomic. When mimicking the installation, the command to
pip install -e exa/
requires a pip install of the following packages:To Reproduce
Steps to reproduce the behavior:
Run the commands in the .travis.yml starting from:
exatomic/.travis.yml
Line 34 in 815b921
to
exatomic/.travis.yml
Line 44 in 815b921
Expected behavior
I expected there to be no additional dependencies for pip to install when installing the git clone of exa.
We already enumerate explicitly the packages needed to cover the exa/tomic stack in the .travis.yml file anyway, so perhaps we should leverage conda to install the above dependencies not already picked up.
Desktop (please complete the following information):
Additional context
Thought it may be a suitable issue for exa instead. But since exa/tomic are tightly coupled, it makes sense that we directly git clone exa during the exatomic build. Therefore it may only pertain to the exatomic build directly.
The text was updated successfully, but these errors were encountered: