Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features to atom_two #205

Open
herbertludowieg opened this issue Oct 26, 2020 · 1 comment
Open

Features to atom_two #205

herbertludowieg opened this issue Oct 26, 2020 · 1 comment
Labels
Enhancement Extend an existing feature

Comments

@herbertludowieg
Copy link
Member

herbertludowieg commented Oct 26, 2020

Is your feature request related to a problem? Please describe.
I think it'd be good if we were to add the frame index to the atom_two table. This would allow users to access the bond distances for specific frames in the atom table which is useful for tracking the bond distance between certain atoms.

Something that I'm not sure if it would be useful would be to change the indexing for the atom0 and atom1 columns to match the set column on the atom table as, again, might make things useful for tracking changes in bond distances.

Edit:
Since the set column in ADF is not the same as an atomic index I think we would need to add a new column such as adx to keep track of the atomic index within each frame. This would require us to add that column into every parse_atom method.

Describe the solution you'd like
Just adding a new column.

Describe alternatives you've considered
None so far really. Not sure if we can do it with the current implementation unless we get the min and max index in each of the atom frames.

Additional context
Not sure yet what this would mean for any of the javascript code.
Edit:
From the small number of tests with visualizing the molecule this does not seem to be an issue.

Would need features addressed in #211

@herbertludowieg herbertludowieg changed the title Changing indexing on atom_two Features to atom_two Nov 6, 2020
@herbertludowieg herbertludowieg mentioned this issue Nov 8, 2020
4 tasks
@tjduigna
Copy link
Contributor

tjduigna commented Nov 3, 2021

I am confused about references to the set column in the atom table. I believe this column is usually used as a foreign key into the basis_set table. I am not sure how it is related to the atom_two table. Could you clarify?

@tjduigna tjduigna added the Enhancement Extend an existing feature label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Extend an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants