Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No i18n support for link-button directive #68

Open
jpmckinney opened this issue Jul 31, 2021 · 3 comments
Open

No i18n support for link-button directive #68

jpmckinney opened this issue Jul 31, 2021 · 3 comments

Comments

@jpmckinney
Copy link
Contributor

jpmckinney commented Jul 31, 2021

The :text: option is not passed through gettext. It is not extracted by Sphinx's gettext builder.

I think the "easy" solution is to put the text in the body of the directive, like all other directives.

I guess this would require a major/minor version change, unless you support both :text: options and directive bodies at once.

@welcome
Copy link

welcome bot commented Jul 31, 2021

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@chrisjsewell
Copy link
Member

Heya, as mentioned in #67, this package is essentially being deprecated for sphinx-design, and that is indeed exactly how it works there: https://sphinx-design.readthedocs.io/en/latest/badges_buttons.html#buttons

@jpmckinney
Copy link
Contributor Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants