From 9610af927b1ae33f9854c73506a37425b1c896b3 Mon Sep 17 00:00:00 2001
From: Ali HAMDI <ahamdi@exoplatform.com>
Date: Mon, 6 Nov 2023 17:01:53 +0100
Subject: [PATCH] fix: remove unused transitive dependency cxf client -
 EXO-64344 (#304)

This will remove an unused transitive dependency cxf-rt-rs-client that causes issues in Unit tests
---
 exo.jcr.component.core/pom.xml                                | 4 ++++
 .../org/exoplatform/services/jcr/ext/ActivityTypeUtils.java   | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/exo.jcr.component.core/pom.xml b/exo.jcr.component.core/pom.xml
index 164686e027..2fb63dee91 100644
--- a/exo.jcr.component.core/pom.xml
+++ b/exo.jcr.component.core/pom.xml
@@ -157,6 +157,10 @@
                <groupId>org.apache.tika</groupId>
                <artifactId>tika-core</artifactId>
             </exclusion>
+            <exclusion>
+               <groupId>org.apache.cxf</groupId>
+               <artifactId>cxf-rt-rs-client</artifactId>
+            </exclusion>
             <exclusion>
                <groupId>org.apache.geronimo.specs</groupId>
                <artifactId>geronimo-stax-api_1.0_spec</artifactId>
diff --git a/exo.jcr.ext.services/src/main/java/org/exoplatform/services/jcr/ext/ActivityTypeUtils.java b/exo.jcr.ext.services/src/main/java/org/exoplatform/services/jcr/ext/ActivityTypeUtils.java
index 97ed2aafab..3338d36f2e 100644
--- a/exo.jcr.ext.services/src/main/java/org/exoplatform/services/jcr/ext/ActivityTypeUtils.java
+++ b/exo.jcr.ext.services/src/main/java/org/exoplatform/services/jcr/ext/ActivityTypeUtils.java
@@ -55,7 +55,7 @@ public static void attachActivityId(Node ownerNode, String activityId) {
       if (!ownerNode.isCheckedOut()) {
         verNode = checkout(ownerNode);
       }
-      if (ownerNode.isNodeType(EXO_ACTIVITY_INFO) == false && ownerNode.canAddMixin(EXO_ACTIVITY_INFO)) {
+      if (!ownerNode.isNodeType(EXO_ACTIVITY_INFO) && ownerNode.canAddMixin(EXO_ACTIVITY_INFO)) {
         ownerNode.addMixin(EXO_ACTIVITY_INFO);
       }
       ownerNode.setProperty(EXO_ACTIVITY_ID, activityId);