Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure "Functional Tests" properly #132

Open
fabasoad opened this issue Jan 4, 2025 · 0 comments
Open

Configure "Functional Tests" properly #132

fabasoad opened this issue Jan 4, 2025 · 0 comments
Assignees
Labels
enhancement Enhancement of the code, not introducing new features. priority-medium This issue may be useful, and needs some attention.

Comments

@fabasoad
Copy link
Owner

fabasoad commented Jan 4, 2025

Is your feature request related to a problem? Please describe

The problem is that currently there are no tests for this GitHub Action configured.

Describe the solution you'd like

Since this GitHub Action works only with the changed files compared to base, the setup might be slightly more difficult than usual. Currently, I am thinking about the following:

  1. CI workflow 1 is triggered on pull_request/push (as usual) and:
    1. Adds new image
    2. Creates new branch and pushes changes into it
    3. Branch should be with the certain pattern, e.g. ci/*
  2. CI workflow 2 is triggered on pushes to ci/* branches and:
    1. Runs GitHub Action on top of new branch
    2. Deletes branch in the very last step

Ideally, on step 1.1 should be also renaming, modification and copying to validate all scenarios. But at least added files is already good enough.

Describe alternatives you've considered

None.

@fabasoad fabasoad added the enhancement Enhancement of the code, not introducing new features. label Jan 4, 2025
@fabasoad fabasoad self-assigned this Jan 4, 2025
@fabasoad fabasoad added the priority-medium This issue may be useful, and needs some attention. label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the code, not introducing new features. priority-medium This issue may be useful, and needs some attention.
Projects
None yet
Development

No branches or pull requests

1 participant