add missing unicode categories in python library #3872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing unicode categories to fix the error
ValueError: Fable error, unknown Unicode category: Ps
when calling for example,Char.IsLetterOrDigit
with left paren '('.I used the values defined in the referenced doc https://docs.microsoft.com/en-us/dotnet/api/system.globalization.unicodecategory?view=net-6.0, and also found that
No
was assigned toUnicodeCategory.OtherLetter
instead ofUnicodeCategory.OtherNumber
.I'm not sure how to test the surrogate category, as I hit an error I left a note about that I didn't get a chance to look into.
The test data was created by running the following script
which groups chars by category and then prints each category with a sample value.