Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Under "codebase", put a link to the GitHub repository #31

Open
ALRubinger opened this issue Nov 27, 2018 · 5 comments
Open

Under "codebase", put a link to the GitHub repository #31

ALRubinger opened this issue Nov 27, 2018 · 5 comments

Comments

@ALRubinger
Copy link
Contributor

Currently missing. The Git URL is there, but let's also link to the GitHub web view.

@ia3andy
Copy link
Contributor

ia3andy commented Nov 28, 2018

@ALRubinger For now I don't have access to the repository type and it can be different from GitHub (Not right now but soon with the Gitea compat for ex).

@quintesse Should we add the repo type to the WA config?

@quintesse
Copy link
Contributor

quintesse commented Nov 28, 2018

@ia3andy that isn't information the creator backend has (or can have). The launcher backend would have to be changed to pass that info in the same way it now passes the SOURCE_REPOSITORY_URL (passing a SOURCE_REPOSITORY_TYPE or _PROVIDER?)

@ALRubinger
Copy link
Contributor Author

@gastaldi Would you mind looking into this as an overarching issue to be handled across components per the feedback in the comments above?

@gastaldi
Copy link
Contributor

@ALRubinger sure, I created fabric8-launcher/launcher-application#603 to track the needed changes in launcher-backend

gastaldi added a commit to fabric8-launcher/launcher-creator-backend that referenced this issue Nov 28, 2018
This is necessary for the welcome app to render the appropriate web view URL and icon

Needed for fabric8-launcher/launcher-creator-welcome-app#31
@ALRubinger ALRubinger added this to the Train K - MVP milestone Dec 6, 2018
@ALRubinger
Copy link
Contributor Author

Removing from Train K as we now have it good enough for MVP: the link to the .git repo already there will be treated by GitHub to redirect to the web page for that repo

@ALRubinger ALRubinger removed this from the Train K - MVP milestone Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants