Dynamically disable submit button #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelPhonso
requested review from
cameochoquer,
Taha-Hassan-Git,
simonryrie and
eliazzo
|
Nice clean solution, looks good to me! I would argue that we shouldn't have .env.example on git ignore because it's just a template that we want to provide to the user and shouldn't have any secrets on it. Maybe best to merge my PR first then rebase / merge main into this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5
Turns out dynamically disabling the submit button on the front end was really quick.
I've also added .env and .env.example to the .gitignore to avoid us pushing any secrets. Didn't refactor any other parts of the code to keep this pr simple
Put down everyone as reviewers for visibility but this could also be merged after a more complex issue if there are other PR's in the works
🦨