Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better type checking in eigensolve_isotropic_media #53

Open
smartalecH opened this issue Oct 31, 2023 · 0 comments
Open

Better type checking in eigensolve_isotropic_media #53

smartalecH opened this issue Oct 31, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@smartalecH
Copy link
Contributor

Currently, if the wavelength parameter within eigensolve_isotropic_media is passed as a float, rather than a jax array, then it throws an obscure error (not directly pointing to the wavelength parameter itself).

It would be good to either

  • explicitly allow for float values and do the necessary conversions under the hood.
  • assert a type up front and throw an error describing why this needs to be the case.
@smartalecH smartalecH added enhancement New feature or request good first issue Good for newcomers labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant