Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Observation Transformer API #503

Open
Skylion007 opened this issue Oct 19, 2020 · 2 comments
Open

Overhaul Observation Transformer API #503

Skylion007 opened this issue Oct 19, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Skylion007
Copy link
Contributor

Skylion007 commented Oct 19, 2020

🚀 Feature

  • We are starting to use Observation Transformers as a general Habitat_Baselines tool and therefore it should be graduated one config level so it's no longer under the RL namespace.
  • Decouple type for ObservationTransformer name, this allows multiple observation transformers of the same class with different args.

Better to do this sooner since more and more people are beginning to rely on ObservationTransformers.

@Skylion007
Copy link
Contributor Author

Issue #500 might be a good time to do this general refactor.

@Skylion007 Skylion007 changed the title Move Observation Transformers Config out of RL Scope Overhaul Observation Transformer API Nov 17, 2020
@Skylion007
Copy link
Contributor Author

Okay, so I think we may need to make the observation transfromer more like the Sensor API so that type and keyname are seperated. That way, a user can define multiple of the same observation_transformers affecting different keys just like they do currently with sensor types. ENABLED_SENSOR could then selected the obs_transformer based on their name, instead of their type:

    sensor = getattr(config.SIMULATOR, f"{sensor_type}_SENSOR")

Similar to this.

@Skylion007 Skylion007 added enhancement New feature or request help wanted Extra attention is needed labels Nov 17, 2020
srama2512 pushed a commit that referenced this issue Mar 15, 2023
* Add replica OBB loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant