Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger for requirements related management #165

Closed
brownsarahm opened this issue Apr 7, 2020 · 7 comments
Closed

Trigger for requirements related management #165

brownsarahm opened this issue Apr 7, 2020 · 7 comments
Assignees

Comments

@brownsarahm
Copy link
Collaborator

can we fix the pipfile, pipfile.lock and docker fiels so that we don't have to update so many separate places for security (and there's fewer separate copies of the notification) like could those be auto generated by travis from the requirements.txt maybe?

while working on this, can possibly address #163 as well

@cegme
Copy link
Collaborator

cegme commented Apr 10, 2020

@brownsarahm @Shine226 When developing wiggum, if you need to install a new package have you been relying on the requirements.txt file?
If you don't primarily use the Pipfile, I can make a dependency so when the requirements.txt file changes, the Pipfile and Pipfile.lock are updated.

@cegme
Copy link
Collaborator

cegme commented Apr 10, 2020

I fixed the current security issue in commit 51d14b3 . I can add an action to update requirements and Pipfile when we establish a workflow.

@brownsarahm
Copy link
Collaborator Author

I use the requirements.txt. And, I've seen more success with the automatic PRs for security issues updating that file than the other two. (which I don't understand, but have experienced repeatedly.

@cegme
Copy link
Collaborator

cegme commented Apr 10, 2020

The Pipfile.lock generated diffs so I have to run a `pipenv lock`` when changing version. If the lock file wasn't versioned security updateds would probably be automatic. I don't think we need the lock unless there are strict version requirements or security concerns for Wiggum. One solution is to remove it.

@brownsarahm brownsarahm added this to the Joss Submission milestone Apr 13, 2020
brownsarahm added a commit that referenced this issue Apr 16, 2020
Removed the Pipfile.lock because it isnt needed. This Address Issue #165
@cegme
Copy link
Collaborator

cegme commented Apr 18, 2020

This was solved by removing the Pipfie.lock. Closed

@cegme cegme closed this as completed Apr 18, 2020
@brownsarahm
Copy link
Collaborator Author

Do the pipfile and docker containers update automatically?

@cegme
Copy link
Collaborator

cegme commented Apr 21, 2020

The Pipfile should auto repair security updates. The

The Pipfile does need to be sync with the requirements.txt when new dependencies are added.

The Dockerfile just specifies an install based on whatever is in the current wiggum.

At this point we could remove the Pipfile and only use the requirements.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants