-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Firefox E2E CI gate #2363
Comments
It seems that uvicorn subprocess somehow crashes with SIGSEGV when setting up firefox for second test... It only happens on github action vm with python3.12+. Cannot figured out the root cause, for it is super hard to debug in action vm.
Possible workaround may be using python3.11 for e2e test or disabling session scope setting of base_url fixture to setup new uvicorn process for every test. |
I'm having issues on another project using ubuntu 24.04 pythons, that fails some test for unknown reasons, while the same test and python version have worked for years without any issue in older version of ubuntu. All this is to suggest that maybe pinning ubuntu to 22.04 fixes this issue too? |
Thanks for looking into this @Cycloctane, that's very valuable feedback 💯 Maybe we should report this to Uvicorn and/or Cython too? It shouldn't be segfaulting like that... 🤔 @Cycloctane out of curiosity, could you try installing Uvicorn with pure Python deps only, i.e., |
Note that in the original failure that I reported though, Uvicorn did not segfault. (Different CPython and package versions were in use.) I'll check if there are any issues or discussions on Uvicorn's side, maybe @Kludex knows more. |
Maybe the original was actually segfault failing, but it does not show details by default. ci log with faulthandler enabled in uvicorn subprocess: https://github.com/Cycloctane/falcon/actions/runs/12612463548/job/35149212673 |
Hm, you may be right @Cycloctane, we might have missed that. OTOH, we do assert the retval to fall within the expected values, so we should have captured that, even if we missed the traceback 🤔 |
I cannot see what original conftest does to check the retval of subprocess. It is not able to detect if uvicorn crashed during the test. I added |
Yes, sorry, you're dead right. I had our main ASGI server tests in mind ( Edit: and thanks once again for tracing this to be a segfault in Uvicorn. For reference, I created a discussion on Uvicorn's side (encode/uvicorn#2557), referencing your CI runs. |
It seems that something has got broken recently, so we had to disable these E2E tests on Firefox.
Was it Firefox 131.0, or anything in SeleniumBase? Or simply an issue with a new default GitHub Actions Ubuntu image?
You can find an example of a failed CI run here: https://github.com/falconry/falcon/actions/runs/11254279330/job/31291767229
The text was updated successfully, but these errors were encountered: