Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login breaks without email set #803

Closed
1 task done
maam27 opened this issue Jun 9, 2024 · 2 comments · Fixed by #807
Closed
1 task done

Login breaks without email set #803

maam27 opened this issue Jun 9, 2024 · 2 comments · Fixed by #807
Labels
bug Something isn't working confirmed This bug has been reproduced released

Comments

@maam27
Copy link

maam27 commented Jun 9, 2024

Description

The user is unable to login to jellyseerr with their jellyfin account if the email has been removed from the account page.

Version

1.9.0

Steps to Reproduce

  1. Go to profile
  2. Click edit settings
  3. empty the email field
  4. logout
  5. attempt to login using jellyfin

Screenshots

No response

Logs

No response

Platform

desktop

Device

pc

Operating System

windows 10

Browser

chrome

Additional Context

Setting the email is forced during the setup process of jellyfin, this oculd explain why the login breaks if it suddenly isn't set. For clarity the email should not be able to be unset, or not be mandatory during the setup.

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@fallenbagel
Copy link
Owner

The intended behavior is email shouldn't be removed. Email is a must (even if it's just nonesense). Thank you for reporting that it can be set as empty (that's not intended)

@fallenbagel fallenbagel added bug Something isn't working confirmed This bug has been reproduced labels Jun 9, 2024
gauthier-th added a commit that referenced this issue Jun 11, 2024
@gauthier-th
fix: empty email in user settings
8bd7589 
Email is mandatory for every user and required during the setup of Jellyseerr, but it is possible to
set it empty afterwards in the user settings. When the email is empty, users are not able to connect
to Jellyseer. This PR makes the email field mandatory in the user settings.

fix #803
@gauthier-th gauthier-th mentioned this issue Jun 11, 2024
Merged
3 tasks
fallenbagel pushed a commit that referenced this issue Jun 11, 2024
@gauthier-th
fix: empty email in user settings (#807)
20863d4 
Email is mandatory for every user and required during the setup of Jellyseerr, but it is possible to
set it empty afterwards in the user settings. When the email is empty, users are not able to connect
to Jellyseer. This PR makes the email field mandatory in the user settings.

fix #803
@fallenbagel
Copy link
Owner

🎉 This issue has been resolved in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

bonswouar pushed a commit to bonswouar/jellyseerr that referenced this issue Jun 14, 2024
@gauthier-th @bonswouar
fix: empty email in user settings (fallenbagel#807)
246e48b 
Email is mandatory for every user and required during the setup of Jellyseerr, but it is possible to
set it empty afterwards in the user settings. When the email is empty, users are not able to connect
to Jellyseer. This PR makes the email field mandatory in the user settings.

fix fallenbagel#803
@Jacouille Jacouille mentioned this issue Jun 21, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working confirmed This bug has been reproduced released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: empty email in user settings fallenbagel/jellyseerr
2 participants
@maam27 @fallenbagel