Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split "Discover Region" and "Currently Streaming on" #890

Closed
1 task done
DrMcCoy opened this issue Jul 24, 2024 · 3 comments · Fixed by #993
Closed
1 task done

Split "Discover Region" and "Currently Streaming on" #890

DrMcCoy opened this issue Jul 24, 2024 · 3 comments · Fixed by #993
Labels
enhancement New feature or request

Comments

@DrMcCoy
Copy link

DrMcCoy commented Jul 24, 2024

Description

Currently, the "Currently Streaming On" information seems to be based on the Discover Region setting. I.e. when I set it to Germany, it shows where it's streaming in Germany. When it's set to All Regions, it shows...US? Production country? That's not clear, but it's not all services in all countries, that's for sure.

I'd like to see these concepts split, so that I can see where something is streaming in Germany (if any), but not filter away things in the Discover section.

Desired Behavior

I'd like two different settings: "Discover Region" and, perhaps, "Streaming Region". The former is solely for filtering in the Discover section, while the latter changes which region the "Currently Streaming On" information is based off of.

Additional Context

No response

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@gauthier-th gauthier-th changed the title [Feature Request] Split "Discover Region" and "Currently Streaming on" Split "Discover Region" and "Currently Streaming on" Sep 15, 2024
@gauthier-th gauthier-th added enhancement New feature or request awaiting triage This issue needs to be reviewed labels Sep 15, 2024
gauthier-th added a commit that referenced this issue Oct 2, 2024
@gauthier-th
feat: add separate setting for streaming region
dc7991b 
Currently, the "Currently Streaming On" information is based on the Discover Region setting. This PR
adds a new setting to specify which region should be used to display the streaming region.

re #890
@gauthier-th gauthier-th mentioned this issue Oct 2, 2024
Merged
3 tasks
@gauthier-th gauthier-th removed the awaiting triage This issue needs to be reviewed label Oct 2, 2024
@gauthier-th gauthier-th linked a pull request Oct 3, 2024 that will close this issue
feat(usersettings): add separate setting for streaming region #993
Merged
3 tasks
gauthier-th added a commit that referenced this issue Nov 12, 2024
@gauthier-th
feat: add separate setting for streaming region
b1506a5 
Currently, the "Currently Streaming On" information is based on the Discover Region setting. This PR
adds a new setting to specify which region should be used to display the streaming region.

re #890
gauthier-th added a commit that referenced this issue Dec 5, 2024
@gauthier-th
feat: add separate setting for streaming region
14680c9 
Currently, the "Currently Streaming On" information is based on the Discover Region setting. This PR
adds a new setting to specify which region should be used to display the streaming region.

re #890
gauthier-th added a commit that referenced this issue Dec 8, 2024
@gauthier-th
feat(usersettings): add separate setting for streaming region (#993)
89831f7 
* feat: add separate setting for streaming region

Currently, the "Currently Streaming On" information is based on the Discover Region setting. This PR
adds a new setting to specify which region should be used to display the streaming region.

re #890

* fix: add missing newline

* fix: rename migration function
thibodelanghe pushed a commit to thibodelanghe/jellyseerr that referenced this issue Dec 18, 2024
@gauthier-th @thibodelanghe
feat(usersettings): add separate setting for streaming region (fallen…
8b34047 
…bagel#993)

* feat: add separate setting for streaming region

Currently, the "Currently Streaming On" information is based on the Discover Region setting. This PR
adds a new setting to specify which region should be used to display the streaming region.

re fallenbagel#890

* fix: add missing newline

* fix: rename migration function
@DrMcCoy
Copy link
Author

DrMcCoy commented Dec 29, 2024

Oh, nice, thanks for implementing this! :)

Just saw it referenced in the release announcement mail. Going to look at how it looks in Jellyseerr tomorrow.

(For some reason I didn't get any update mails for this ticket, though, even though I'm the author and still subscribed to this ticket? That's weird.)

@gauthier-th
Copy link
Collaborator

(For some reason I didn't get any update mails for this ticket, though, even though I'm the author and still subscribed to this ticket? That's weird.)

Probably because no message was sent here. Just references to this issue.

@DrMcCoy
Copy link
Author

DrMcCoy commented Dec 30, 2024

Okay, having looked at the new version of Jellyseerr, this is exactly what I wanted. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(usersettings): add separate setting for streaming region fallenbagel/jellyseerr
2 participants
@DrMcCoy @gauthier-th