Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo_example_validation.m gives not consistent results with diffusion #100

Closed
andreafarina opened this issue Oct 16, 2024 · 1 comment
Closed

Comments

@andreafarina
Copy link
Contributor

andreafarina commented Oct 16, 2024

Dear @fangq,
I've run the example demo_example_validation.m and, after your last update, the results between diffusion and MMC are not in agreement anymore when using gpu. There is probably some normalization that has not been set after the GPU Photon sharing update. Good agreement if using cfg.gpuid = -1.
image.

Thanks a lot!

Best regards!

Andrea

@fangq fangq closed this as completed in c646344 Oct 16, 2024
@fangq
Copy link
Owner

fangq commented Oct 16, 2024

@andreafarina, thanks for the report. I noticed that this is a regression caused by the recent implementation of the normalization for photon sharing (#99) on the GPU. now it is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants