Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rundir = "." should not be required for IT tests #5

Open
apesternikov opened this issue Aug 21, 2023 · 0 comments
Open

rundir = "." should not be required for IT tests #5

apesternikov opened this issue Aug 21, 2023 · 0 comments

Comments

@apesternikov
Copy link
Contributor

currently the canonical way for IT tests to locate the setup binary is through

data = [
   ":target_it.setup"
],
args = [
   "-setup",
   "$(location :target_it.setup")",
],

which also require

rundir = "."

in go tests because the default current working dir for go tests is the test source directory to be compatible with the non-bazel way of running tests.
IT setup target should be able to locate runfiles if test is started with or without rundir parameter.
shraykay pushed a commit to shraykay/rules_gitops that referenced this issue Jan 22, 2025
@nazzzzz @shraykay
# This is a combination of 23 commits.
503f475 
# This is the 1st commit message:

app name first

# This is the commit message nazzzzz#2:

clean up file

# This is the commit message nazzzzz#3:

fix reference to proto package

# This is the commit message fasterci#4:

better parse

# This is the commit message fasterci#5:

fix again

# This is the commit message fasterci#6:

fix again

# This is the commit message fasterci#7:

fix again

# This is the commit message fasterci#8:

fix again

# This is the commit message fasterci#9:

fix again

# This is the commit message fasterci#10:

fix again

# This is the commit message fasterci#11:

add debug statements for seeing if branch is dirty

# This is the commit message fasterci#12:

fix again

# This is the commit message fasterci#13:

fix again

# This is the commit message fasterci#14:

fix again

# This is the commit message fasterci#15:

fix again

# This is the commit message fasterci#16:

fix again

# This is the commit message fasterci#17:

fix again

# This is the commit message fasterci#18:

fix again

# This is the commit message fasterci#19:

fix again

# This is the commit message fasterci#20:

fix again

# This is the commit message fasterci#21:

fix again

# This is the commit message fasterci#22:

fix again

# This is the commit message fasterci#23:

fix again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apesternikov