Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multigraph support? #8

Open
fedarko opened this issue Mar 30, 2023 · 0 comments
Open

Multigraph support? #8

fedarko opened this issue Mar 30, 2023 · 0 comments
Labels
question Further information is requested

Comments

@fedarko
Copy link
Owner

fedarko commented Mar 30, 2023

If we see a FASTG file containing an edge declaration like

>EDGE_1_length_9_cov_4.5:EDGE_3_length_5_cov_16.5',EDGE_3_length_5_cov_16.5';
ATCGCCCAT

... then, as of pyfastg v0.1.0, pyfastg's parse_fastg() function will throw an error saying that Node 1+ has duplicate outgoing adjacencies. The rationale for this behavior is that I haven't seen any SPAdes-dialect FASTG files that contain "parallel adjacencies," and I'm not sure if supporting these would be useful for anyone. (Also, the whole "edge and adjacency" paradigm of FASTG files means that defining multiple "adjacencies" between the same two edges becomes kind of hazy.)

That being said: if these sorts of graphs can exist in practice, then I think it should be fairly simple to modify pyfastg to support them (we would just change our return type from nx.DiGraph to nx.MultiDiGraph). If you (whomstever is reading this) has any thoughts on this, please comment below.

@fedarko fedarko added the question Further information is requested label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant