Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedora-review rpmlint fails to run on installed RPMs #3569

Closed
FaramosCZ opened this issue Jan 3, 2025 · 4 comments
Closed

fedora-review rpmlint fails to run on installed RPMs #3569

FaramosCZ opened this issue Jan 3, 2025 · 4 comments
Assignees
Labels

Comments

@FaramosCZ
Copy link

I run into this problem every time. The rpmlint is called but seems to effectively do nothing as it can't reach the files to be checked.

rpmlint:
(none): E: there is no installed rpm xxx
(none): E: there is no installed rpm yyy
(none): E: there is no installed rpm zzz
...
There are no files to process nor additional arguments.
Nothing to do, aborting.
...
0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 
...

Here I prepared an example on a trivial package:
https://download.copr.fedorainfracloud.org/results/mschorm/mariadb-connector-odbc/fedora-rawhide-x86_64/08467147-mariadb-connector-odbc/fedora-review/fedora-review.log.gz

INFO: Running in chroot: ["echo 'rpmlint:'; rpmlint --installed mariadb-connector-odbc mariadb-connector-odbc-debuginfo; echo 'rpmlint-done:'"]
Start: chroot ["echo 'rpmlint:'; rpmlint --installed mariadb-connector-odbc mariadb-connector-odbc-debuginfo; echo 'rpmlint-done:'"]
rpmlint:
(none): E: there is no installed rpm "mariadb-connector-odbc".
(none): E: there is no installed rpm "mariadb-connector-odbc-debuginfo".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 
rpmlint-done:
Finish: chroot ["echo 'rpmlint:'; rpmlint --installed mariadb-connector-odbc mariadb-connector-odbc-debuginfo; echo 'rpmlint-done:'"]
Finish: run

01-03 12:07 root         DEBUG        CheckRpmlintInstalled completed: 16.915 seconds
01-03 12:07 root         DEBUG    Running check: CheckRpmlintDebuginfo
01-03 12:07 root         DEBUG    Run command: rpmlint --ignore-unused-rpmlintrc --rpmlintrc /tmp/tmp6i18tkup /var/lib/copr-rpmbuild/results/mariadb-connector-odbc-debuginfo-3.2.4-1.fc42.x86_64.rpm
01-03 12:07 root         DEBUG        CheckRpmlintDebuginfo completed: 0.524 seconds
@FrostyX
Copy link
Member

FrostyX commented Jan 3, 2025

Thank you @FaramosCZ,
somebody will take a look at this.

First step should probably be testing if this works outside Copr through fedora-reivew alone.

@praiskup praiskup added the bug label Jan 6, 2025
@praiskup
Copy link
Member

praiskup commented Jan 6, 2025

We still need to find where the issue is, and triage.

@praiskup praiskup moved this from Needs triage to In 3 months in CPT Kanban Jan 6, 2025
@praiskup praiskup moved this from In 3 months to In Progress in CPT Kanban Jan 13, 2025
@FrostyX
Copy link
Member

FrostyX commented Jan 23, 2025

@FaramosCZ I finally got to this ticket, sorry for the wait.

It doesn't seem broken to me. Check this out https://download.copr.fedorainfracloud.org/results/mschorm/mariadb-connector-odbc/fedora-rawhide-x86_64/08467147-mariadb-connector-odbc/fedora-review/review.txt

There is the section that you found in the log, which looks broken

Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "mariadb-connector-odbc".
(none): E: there is no installed rpm "mariadb-connector-odbc-debuginfo".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 

but above it, there are two sections with checks on the non-installed files

Rpmlint
-------
Checking: mariadb-connector-odbc-3.2.4-1.fc42.x86_64.rpm
          mariadb-connector-odbc-3.2.4-1.fc42.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp02uxi0js')]
checks: 32, packages: 2

mariadb-connector-odbc.spec:51: W: macro-in-comment %_vpath_builddir
mariadb-connector-odbc.x86_64: E: invalid-soname /usr/lib64/libmaodbc.so libmaodbc.so
mariadb-connector-odbc.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/libmaodbc.pc
 2 packages and 0 specfiles checked; 1 errors, 2 warnings, 14 filtered, 1 badness; has taken 0.3 s 




Rpmlint (debuginfo)
-------------------
Checking: mariadb-connector-odbc-debuginfo-3.2.4-1.fc42.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp6i18tkup')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.2 s 

The important lines being

mariadb-connector-odbc.spec:51: W: macro-in-comment %_vpath_builddir
mariadb-connector-odbc.x86_64: E: invalid-soname /usr/lib64/libmaodbc.so libmaodbc.so
mariadb-connector-odbc.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/libmaodbc.pc

was this what you were looking for? Or am I missing something?

@nikromen
Copy link
Member

nikromen commented Feb 3, 2025

seems like not a bug. @FaramosCZ if you think we are wrong and this is worth debugging again, please reopen this

@nikromen nikromen closed this as completed Feb 3, 2025
@nikromen nikromen moved this from In Progress to Done in CPT Kanban Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants