Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting a Koji build without cookies ends on a blank page #125

Closed
ppisar opened this issue Apr 22, 2024 · 3 comments · Fixed by #130
Closed

Submitting a Koji build without cookies ends on a blank page #125

ppisar opened this issue Apr 22, 2024 · 3 comments · Fixed by #130
Assignees

Comments

@ppisar
Copy link

ppisar commented Apr 22, 2024

I have cookies globally disabled in my web browser. When I submitted a Koji log with a form at https://log-detective.com/#koji, I ended up on a page without any text. After enabling cookies for https://log-detective.com/ I was able to precede.

I recommend adding a warning on that empty page that cookies are required. Similarly you have a warning when JavaScript is disabled.

@nikromen
Copy link
Member

that's odd. I thought we don't use cookies for log detective, right @FrostyX ?

@FrostyX
Copy link
Member

FrostyX commented Apr 22, 2024

I thought so as well. I did everything using localStorage. Maybe React uses cookies implicitly for something?

@ppisar
Copy link
Author

ppisar commented Apr 22, 2024

Indeed. Firefox debugger does not show any Cookies headers transferred when I enable cookies. Maybe Firefox blocks more things than cookies when a permission to Store cookies is Block. Firefox console shows unhelpfully:

Cookie “” has been rejected by user set permissions. 2 [x86_64](https://log-detective.com/contribute/koji/2441874/x86_64)
Request to access cookies or storage on “https://log-detective.com/contribute/koji/2441874/x86_64” was blocked because of custom cookie permission.

Cookie “” has been rejected by user set permissions. [style.css](https://log-detective.com/css/style.css)
Cookie “” has been rejected by user set permissions. [fedora.svg](https://log-detective.com/img/fedora.svg)
Cookie “” has been rejected by user set permissions. [main.js](https://log-detective.com/static/js/main.js)
Cookie “” has been rejected by user set permissions. [x86_64](https://log-detective.com/frontend/contribute/koji/2441874/x86_64)
Cookie “” has been rejected by user set permissions. [favicon.ico](https://log-detective.com/img/favicon.ico)
DOMException: The operation is insecure.
    Pr https://log-detective.com/static/js/main.js:1060
    Pr https://log-detective.com/static/js/main.js:1060
    Qr https://log-detective.com/static/js/main.js:1068
    c https://log-detective.com/static/js/main.js:903
    Fm https://log-detective.com/static/js/main.js:903
    Gm https://log-detective.com/static/js/main.js:905
    lm https://log-detective.com/static/js/main.js:889
    _run https://log-detective.com/static/js/main.js:897
    Gm https://log-detective.com/static/js/main.js:905
    Ue https://log-detective.com/static/js/main.js:129
    Lg https://log-detective.com/static/js/main.js:129
    pi https://log-detective.com/static/js/main.js:135
    jh https://log-detective.com/static/js/main.js:175
    kh https://log-detective.com/static/js/main.js:176
    Pd https://log-detective.com/static/js/main.js:190
    eb https://log-detective.com/static/js/main.js:189
    Id https://log-detective.com/static/js/main.js:187
    Fb https://log-detective.com/static/js/main.js:185
    enqueueForceUpdate https://log-detective.com/static/js/main.js:234
    forceUpdate https://log-detective.com/static/js/main.js:13
    flush_queues https://log-detective.com/static/js/main.js:887
    run_queues https://log-detective.com/static/js/main.js:887
    a https://log-detective.com/static/js/main.js:886
[main.js:148:316](https://log-detective.com/static/js/main.js)
Uncaught DOMException: The operation is insecure.
    Pr https://log-detective.com/static/js/main.js:1060
    Pr https://log-detective.com/static/js/main.js:1060
    Qr https://log-detective.com/static/js/main.js:1068
    c https://log-detective.com/static/js/main.js:903
    Fm https://log-detective.com/static/js/main.js:903
    Gm https://log-detective.com/static/js/main.js:905
    lm https://log-detective.com/static/js/main.js:889
    _run https://log-detective.com/static/js/main.js:897
    Gm https://log-detective.com/static/js/main.js:905
    Ue https://log-detective.com/static/js/main.js:129
    Lg https://log-detective.com/static/js/main.js:129
    pi https://log-detective.com/static/js/main.js:135
    jh https://log-detective.com/static/js/main.js:175
    kh https://log-detective.com/static/js/main.js:176
    Pd https://log-detective.com/static/js/main.js:190
    eb https://log-detective.com/static/js/main.js:189
    Id https://log-detective.com/static/js/main.js:187
    Fb https://log-detective.com/static/js/main.js:185
    enqueueForceUpdate https://log-detective.com/static/js/main.js:234
    forceUpdate https://log-detective.com/static/js/main.js:13
    flush_queues https://log-detective.com/static/js/main.js:887
    run_queues https://log-detective.com/static/js/main.js:887
    a https://log-detective.com/static/js/main.js:886
[main.js:1060](https://log-detective.com/static/js/main.js)

@praiskup praiskup moved this from Needs triage to In 3 months in CPT Kanban Apr 24, 2024
@praiskup praiskup moved this from In 3 months to In Progress in CPT Kanban Apr 29, 2024
FrostyX added a commit to FrostyX/log-detective-website that referenced this issue May 12, 2024
@praiskup praiskup moved this from In Progress to Done in CPT Kanban May 20, 2024
nikromen pushed a commit to nikromen/log-detective-website that referenced this issue Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants