Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey to disable/enable #162

Open
Zod1234 opened this issue Sep 10, 2023 · 5 comments
Open

Hotkey to disable/enable #162

Zod1234 opened this issue Sep 10, 2023 · 5 comments

Comments

@Zod1234
Copy link

Zod1234 commented Sep 10, 2023

The problem with scaling not built ingame is that text can suffer greatly. Some games I can't read the text. If we had a hotkey one could cycle it off, read whatever and turn it back on.

Ideally, I would think it would be great if a joystick combo invoked this. Looking at the other shortcuts they are keyboard shortcuts, maybe it would be a out of scope for this to have joystick bindings, but say both joystick buttons as a combo would be great.

@fholger
Copy link
Owner

fholger commented Sep 10, 2023

This has been asked before, but it is unfortunately not generally possible. Such a feature would rely on games reacting to resolution changes, but not all games do, and for those that do, it can cause significant stutter or freezing while the game regenerates its rendering resources.

@Zod1234
Copy link
Author

Zod1234 commented Sep 10, 2023

that's too bad. but I just learned steamvr has dynamic resolution functionality but only for native steamvr headsets. i wonder how does it accomplish this without having the impacts you described. what about scaling the decreaseUpscalingRadius down to where it has no effect?

@fholger
Copy link
Owner

fholger commented Sep 10, 2023

I have never heard of such a feature in SteamVR, and if it existed, it would have the exact same issues.

Lowering the radius to zero would have the opposite effect of what you want - the whole image would be rendered at the lower resolution.

@Zod1234
Copy link
Author

Zod1234 commented Sep 10, 2023

I misunderstood what someone said about steamvr, i thought it was dynamic.

I meant increasing the radius to max so in effect the entire image is rendered at higher resolution.

@fholger
Copy link
Owner

fholger commented Sep 10, 2023

It is not, though - the radius controls the area that is getting upscaled. It is still rendered at the lower resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants