From 4a033793d13c741eadc190d9a7df8c6b3dcaa126 Mon Sep 17 00:00:00 2001 From: JayasriR <124573358+JayasriR@users.noreply.github.com> Date: Wed, 22 Jan 2025 16:31:28 +0000 Subject: [PATCH] Oscar Twomey New SpecificAsset data type - Release (#3337) * New SpecificAsset data type TASK-8629: Create new SpecificAsset data types and replace existing Asset attribute on CollateralCriteria. * Update RELEASE.md Added detail on the new data type SpecificAsset replacing Asset in the CollateralCriteria attributes * Update RELEASE.md Change to wording * Update RELEASE.md Update to formatting * Update eligible-collateral-representation.md Updated CollateralCriteria attributes by replacing `Asset` with `SpecificAsset` as per requirements in STORY-3653 * Updated wording of attribute description * Update eligible-collateral-representation.md Updated wording to description of `SpecificAsset` * Update RELEASE.md Updated to make the content more specific to the change. * Update RELEASE.md * Update RELEASE.md --------- Co-authored-by: Oscar Twomey Co-authored-by: eacunaISDA <82891014+eacunaISDA@users.noreply.github.com> --- RELEASE.md | 19 +++++++++++-------- docs/eligible-collateral-representation.md | 2 +- .../rosetta/product-collateral-type.rosetta | 4 +++- 3 files changed, 15 insertions(+), 10 deletions(-) diff --git a/RELEASE.md b/RELEASE.md index 5a896ea080..18e9695ab1 100644 --- a/RELEASE.md +++ b/RELEASE.md @@ -1,18 +1,21 @@ -# *CDM - Eligible Collateral condition logic* +# *Product Model - Addition of SpecificAsset to CollateralCriteria* _Background_ -A recent enhancement to the validation in the Rune DSL has highlighted some logic defects in the conditions that are applied on `EligibleCollateralCriteria`. This release does not change the functionality but ensures that the logic will work correctly in all possible scenarios. +The choice data type `CollateralCriteria` was introduced in [Release 6.0.0-dev.90](https://github.com/finos/common-domain-model/releases/tag/6.0.0-dev.90). It combines all the criteria terms that previously appeared in `AssetCriteria` and `IssuerCriteria`. + +The `Asset` choice data type was originally included in `CollateralCriteria` but was deemed difficult to differentiate from the `AssetType` attribute. This release is an enhancement from `Asset` to the new data type `SpecificAsset` to improve the usability of the model. _What is being released?_ -The following three conditions were impacted: -- ConcentrationLimitTypeIssueOSAmountDebtOnly -- ConcentrationLimitTypeMarketCapEquityOnly -- AverageTradingVolumeEquityOnly +This release added `SpecificAsset` to the `CollateralCriteria` attributes, to replace the original `Asset`. + +_Backward-incompatible changes_ -The fixes ensure that the logic works correctly when there are multiple concentration limits. +None. _Review Directions_ -The changes can be reviewed in PR: [#3326](https://github.com/finos/common-domain-model/pull/3326). +The addition of the new attributes `Asset` to `CollateralCriteria` can be reviewed in PR: [#3321](https://github.com/finos/common-domain-model/pull/3321) + +The adition of the attribute `SpecificAsset` to replace `Asset` can be reviewed in PR: [#3335](https://github.com/finos/common-domain-model/pull/3335) diff --git a/docs/eligible-collateral-representation.md b/docs/eligible-collateral-representation.md index 99e640e1bd..071fc88f26 100644 --- a/docs/eligible-collateral-representation.md +++ b/docs/eligible-collateral-representation.md @@ -238,7 +238,7 @@ choice CollateralCriteria: SovereignAgencyRating <"Criteria is the agency rating(s) of the country of the issuer."> AssetAgencyRating <"Criteria is the agency rating(s) of the collateral asset."> AssetMaturity <"Criteria is the maturity characteristics of the collateral asset."> - Asset <"Criteria is a specifically identified asset."> + SpecificAsset <"Criteria is a specifically identified asset"> CollateralTaxonomy <"Criteria is the taxonomy characteristics of an collateral."> ListingExchange <"Criteria is that the collateral is listed on a specific exchange."> ListingSector <"Criteria is the industry sector of the collateral asset."> diff --git a/rosetta-source/src/main/rosetta/product-collateral-type.rosetta b/rosetta-source/src/main/rosetta/product-collateral-type.rosetta index 54735791a4..90dbb3df09 100644 --- a/rosetta-source/src/main/rosetta/product-collateral-type.rosetta +++ b/rosetta-source/src/main/rosetta/product-collateral-type.rosetta @@ -230,7 +230,7 @@ choice CollateralCriteria: <"The possible different terms that can be combined, SovereignAgencyRating <"Criteria is the agency rating(s) of the country of the issuer."> AssetAgencyRating <"Criteria is the agency rating(s) of the collateral asset."> AssetMaturity <"Criteria is the maturity characteristics of the collateral asset."> - Asset <"Criteria is a specifically identified asset."> + SpecificAsset <"Criteria is a specifically identified asset"> CollateralTaxonomy <"Criteria is the taxonomy characteristics of an collateral."> ListingExchange <"Criteria is that the collateral is listed on a specific exchange."> ListingSector <"Criteria is the industry sector of the collateral asset."> @@ -367,3 +367,5 @@ type DeliveryAmount: <"A class to specify the application of Interest Amount wit condition: one-of + +type SpecificAsset extends Asset: <"A single, specifically identified Asset chosen from the Asset data type"> \ No newline at end of file