Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Relational data beta feature isn't valid in the Profile Validation schema #1708

Open
deinspanjer opened this issue Sep 29, 2020 · 3 comments · May be fixed by #1709
Open

Relational data beta feature isn't valid in the Profile Validation schema #1708

deinspanjer opened this issue Sep 29, 2020 · 3 comments · May be fixed by #1709
Labels
bug Something isn't working

Comments

@deinspanjer
Copy link

deinspanjer commented Sep 29, 2020 •
edited
Loading

Bug report

Description of the bug

https://github.com/finos/datahelix/blob/master/docs/user/ProfileValidation.md
https://github.com/finos/datahelix/blob/master/profile/src/main/resources/profileschema/datahelix.schema.json
The JSON Schema for profile objects was not modified to support the new relationships field.

Additional context:

  • Which version of the generator?
    Master 497eb5a / v2.3.0
@deinspanjer deinspanjer added the bug Something isn't working label Sep 29, 2020
@deinspanjer
Copy link
Author

As an additional "nice to have", it would be great to add a link to docs/RelationalData.md in the UserGuide.

@tjohnson-scottlogic
Copy link
Contributor

Thanks for reporting :)

tjohnson-scottlogic added a commit to tjohnson-scottlogic/datahelix that referenced this issue Oct 1, 2020
@tjohnson-scottlogic
fix(finos#1708): Update schema to support the beta relational data fe…
cb32b5c 
…ature
@tjohnson-scottlogic tjohnson-scottlogic linked a pull request Oct 1, 2020 that will close this issue
Open
@tjohnson-scottlogic
Copy link
Contributor

Hi @deinspanjer , I think I've managed to extend the schema to cover it now (except the extents that is). Does that now work for your profile?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Schema update for relational data tjohnson-scottlogic/datahelix
2 participants
@deinspanjer @tjohnson-scottlogic