-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify build process #117
Comments
Oh and we could use esbuild's |
Ok I understand now that during development, we simply don't use any bundling. This is probably some of the reason for some of the things on this list. Makes me think of snwopack. But in general I'd rather get rid of build depndencies than add more :) |
Good find regarding |
👍
I'd be super happy trying out snowpack v3 for drive today! I've had good experiences using it for https://github.com/matheus23/flatmate.
👍
I'm crossing my fingers that it works with snowpack 😅 So, in general, would you be happier with drive being powered by snowpack? |
Well, we used snowpack previously and moved away from it. The reason we copy those few node modules isn't for Drive itself, it's for the https://github.com/fission-suite/drive/blob/master/src/Static/Html/Reception.html And we'd still need that download task https://github.com/fission-suite/drive/blob/master/Justfile#L73-L76 because those dependencies aren't written in ES6, so you can't use them directly from node_modules with snowpack, even with their commonjs compatibility layer. |
That said, if the HMR is much better for you with snowpack, feel free to add it. |
What I originally loved about snowpack is now https://www.npmjs.com/package/esinstall/ |
Seeing #116 made me remember I had some questions about the build process in drive:
--minify
flag?Can we simplify the build process?
The text was updated successfully, but these errors were encountered: