Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory fails to load if asset not available on pretty path #121

Open
expede opened this issue Mar 31, 2021 · 2 comments
Open

Directory fails to load if asset not available on pretty path #121

expede opened this issue Mar 31, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@expede
Copy link
Member

expede commented Mar 31, 2021

Summary

Problem

When the pretty links are broken, Drive fails to load the directory with the related content. Issue persists when wiping Drive data from browser setting, and trying with fresh login.

Side topic: I should also note that it's odd that the /p/ is not generated, and that Drive is looking for a path at /pretty/

Impact

Unable to use portions of Drive

Solution

I assume that this is failing because it can't grab a preview image? In that case, fail gracefully with a "no preview", or use the userland path instead.

Detail

Describe the bug

Unable to load directory when any links are broken.

To Reproduce
Steps to reproduce the behavior:

  1. Go to drive.fission.codes
  2. Sign in
  3. Click on Public
  4. Upload a bunch of images
  5. Wait for uploads to report completed
  6. Navigate away
  7. Return to Public
  8. Unable to load page with a "get me out of here" button

Expected behavior
Can load directory

Screenshots

Screen Shot 2021-03-31 at 1 26 10 PM

Screen Shot 2021-03-31 at 1 26 42 PM

Screen Shot 2021-03-31 at 1 26 31 PM

Screen Shot 2021-03-31 at 1 34 45 PM

Screen Shot 2021-03-31 at 1 38 25 PM

Desktop (please complete the following information):

  • OS: macOS 11.2.3
  • Browser Firefox
  • Version 87.0
@expede expede added the bug Something isn't working label Mar 31, 2021
@icidasset
Copy link
Contributor

To do:

  1. Figure out why the /p path is missing and fix that
  2. Make it fall back to /public/.../userland

@expede
Copy link
Member Author

expede commented Mar 31, 2021

I'd also suggest

  1. Fall back to "no preview available" if userland is missing

Yes that's another state for the FE to handle (either Err or Nothing), but lowering the blast radius is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants